feat(io): compile GooseFS metadata and page caches - #9263
Open
XuQianJin-Stars wants to merge 1 commit into
Open
XuQianJin-Stars wants to merge 1 commit into
XuQianJin-Stars wants to merge 1 commit into
Conversation
XuQianJin-Stars
force-pushed
the
feat/goosefs-opendal-0.59.2-client-caches
branch
from
September 16, 2026 10:47
0b8596f to
16c3067
Compare
Depend on opendal-service-goosefs 0.59.2 so Cargo unifies metadata-cache and page-cache-io-uring. Pin goosefs-sdk 0.2.2 so metadata_cache_enabled stays off until GOOSEFS_METADATA_CACHE_ENABLED=true.
XuQianJin-Stars
force-pushed
the
feat/goosefs-opendal-0.59.2-client-caches
branch
from
September 16, 2026 11:01
16c3067 to
ee4cfe2
Compare
Contributor
There was a problem hiding this comment.
✅ Gate recommendation: approve.
The rebased revision preserves the verified behavior: goosefs-sdk resolves to 0.2.2, both GooseFS caches are compiled, and metadata and page caching remain runtime opt-ins. Mutable tag freshness therefore remains protected by default.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depend on opendal-service-goosefs 0.59.2 directly so Cargo unifies
metadata-cache and page-cache-io-uring into the same GooseFS client
build as opendal/services-goosefs.
Pin goosefs-sdk 0.2.2 in Lance (no OpenDAL bump). OpenDAL 0.59.2's
^0.2.1 requirement unifies onto 0.2.2. 0.2.2 keeps
metadata_cache_enabled off by default, matching Java
goosefs.user.metadata.cache.enabled, so compiling metadata-cache nolonger serves a 10-minute stale FileInfo for overwritten
_refs/tags/.json.
This compiles the caches into lance-io, pylance, and lance-jni whenever
the goosefs feature is enabled. Runtime behavior stays off until
configured:
GOOSEFS_METADATA_CACHE_ENABLED=trueto opt inGOOSEFS_USER_CLIENT_CACHE_ENABLED=trueandGOOSEFS_USER_CLIENT_CACHE_DIRS / goosefs.user.client.cache.dirsBuild with GooseFS (these also compile metadata-cache and page-cache-io-uring):
Test plan