Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #9495; like the rest of the stack it should wait for #9485.
#7073 lets applications define their own semantic types as Arrow extension types over a core type. Readers that do not know an extension return the storage type, and implementations must keep the extension name and metadata through every rewrite. This checks that promise and brings the two type mappings that serialize schemas in line with tables whose output layouts include views.
An extension Lance does not know keeps its name and metadata through appends in another layout,
add_columns,drop_columns,alter_columns, and compaction in both modes. This holds on new 2.3 tables, on migrated tables, and on legacy tables. No code needed to change; the test pins it.Utf8Viewmaps toutf8andBinaryViewtobinary, so describing a table read as views no longer fails.lance::arrow::jsonserializes views asstring_viewandbinary_viewand reads the canonicaldecimal:<p>:<s>.The discussion's open decision 2, a Lance-owned
lance-schema:extension-namekey for layering extensions on Blob v2 orjson, is not implemented, because it is still open.