Skip to content

feat: read the .defaults files in the env var verifier - #1247

Merged
RiskeyL merged 2 commits into
mainfrom
feat/env-verifier-reads-defaults
Nov 18, 2026
Merged

RiskeyL merged 2 commits into
mainfrom
feat/env-verifier-reads-defaults

Conversation

@RiskeyL

@RiskeyL RiskeyL commented Nov 18, 2026

Copy link
Copy Markdown
Contributor

Since Dify 1.19.0 the tracked defaults live in docker/envs/**/*.defaults. The env var verifier never read them, so a full run against 1.20.0 reported 691 issues, nearly all false.

The verifier now:

  • reads docker/.env.example, the .defaults files, and the optional *.env.example templates, and prints the part each plays in a stock installation
  • treats commented lines as names without defaults, so they no longer need ignore-list entries
  • follows container variable mappings and the colon-less ${VAR-x} form

A full run now reports 20 issues: real doc errors, one verifier blind spot (MODE), and variables that belong on the ignore list. 24 new tests cover the parser and both modes.

The rule pack's Source of Truth and verifier sections describe the layout, and the release-sync detection table now flags changes to .defaults files.

Closes DC-446

Since Dify 1.19.0 the tracked defaults live in docker/envs/**/*.defaults, which the verifier never read, so a full run against 1.20.0 reported 691 issues, nearly all false. It now reads all three kinds of env file with the part each plays in a stock installation, treats commented lines as names without defaults, and follows container variable mappings. A full run now reports 20 issues. Adds 24 tests.

The rule pack's Source of Truth and verifier sections now describe this layout, and a value a .defaults line builds from another setting counts as the default.
The release-sync detection table left out docker/envs/**/*.defaults, so default changes there went unflagged, and the style overrides cited a secret-default wording the page no longer uses.
Copilot AI balanced review requested due to automatic review settings November 18, 2026 14:23
@mintlify

mintlify Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

Preview deployment for your docs. Learn more about Mintlify Previews.

Project Status Preview Updated
dify-ce-cloud-docs 🟢 Ready View Preview Nov 18, 2026, 2:24 PM

💡 Tip: Enable Automations to automatically generate PRs for you.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing. Review the Copilot code review billing settings.

@RiskeyL
RiskeyL merged commit b8b1bbe into main Nov 18, 2026
1 of 2 checks passed
@RiskeyL
RiskeyL deleted the feat/env-verifier-reads-defaults branch November 18, 2026 14:29

This branch was successfully deployed

1 active deployment
staging — 15ef5a28 Deployed Nov 18, 2026 by mintlify[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants