Repository navigation
feat: read the .defaults files in the env var verifier - #1247
Merged
Merged
Conversation
Since Dify 1.19.0 the tracked defaults live in docker/envs/**/*.defaults, which the verifier never read, so a full run against 1.20.0 reported 691 issues, nearly all false. It now reads all three kinds of env file with the part each plays in a stock installation, treats commented lines as names without defaults, and follows container variable mappings. A full run now reports 20 issues. Adds 24 tests. The rule pack's Source of Truth and verifier sections now describe this layout, and a value a .defaults line builds from another setting counts as the default.
The release-sync detection table left out docker/envs/**/*.defaults, so default changes there went unflagged, and the style overrides cited a secret-default wording the page no longer uses.
Contributor
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Automations to automatically generate PRs for you. |
Ill-donut
approved these changes
Nov 18, 2026
Contributor
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing. Review the Copilot code review billing settings.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since Dify 1.19.0 the tracked defaults live in
docker/envs/**/*.defaults. The env var verifier never read them, so a full run against 1.20.0 reported 691 issues, nearly all false.The verifier now:
docker/.env.example, the.defaultsfiles, and the optional*.env.exampletemplates, and prints the part each plays in a stock installation${VAR-x}formA full run now reports 20 issues: real doc errors, one verifier blind spot (
MODE), and variables that belong on the ignore list. 24 new tests cover the parser and both modes.The rule pack's Source of Truth and verifier sections describe the layout, and the release-sync detection table now flags changes to
.defaultsfiles.Closes DC-446