Repository navigation
feat(desktop): add Help → Product Guide and refresh the guide for checkpoint 3748 - #533
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
lastobelus
changed the title
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 13f60814a1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Validation update for The production native menu has also been constructed successfully in an isolated Electron runtime, without a backend or changing the installed app. Actual native menu selection, visibly opening the guide through the OS handler, and authentic before/after menu captures remain unverified. Keeping the PR open for that remaining acceptance. |
024232b to
8199ca4
Compare
|
Native QA update for The attached image is a lossless rectangular crop of the actual native Help-menu screenshot, limited to the added Product Guide item to exclude private background content. No pixels were regenerated or retouched.
The before-menu image remains unavailable because screen-capture permission is denied in the automation session. The baseline production menu was verified through the real Electron runtime and accessibility tree, but that is not a visual capture. No before image or capture waiver is claimed. |
13f6081 to
c0ff597
Compare
|
@codex review |
|
Codex Review: Didn't find any major issues. 🎉 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Add a trusted local-document entry and explain the six product decisions against a verified built checkpoint. Carry-Group: incubator Carry-Observation: This desktop help convenience and its pinned guide are one feature; the Help action does not depend on a selected thread or remote project.
Retain the final clarity edits and exact-checkpoint source links from the resumed writing pass. Carry-Group: incubator Carry-Observation: These copy edits belong to the Help-menu product guide and preserve its pinned checkpoint and private-import behavior.
c0ff597 to
463c9ca
Compare
|
The maintainer explicitly waived only the missing native before-image requirement and authorized merge once the current CI and review gates pass. Native Help selection, successful OS handoff, visible guide rendering and the safe uploaded after-image are complete. No baseline capture is claimed. All current-head/current-base CI, review and guarded-merge requirements remain in force. |
|
@codex review |
|
Codex Review: Didn't find any major issues. Already looking forward to the next diff. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
The desktop Help menu has no way to open the locally maintained product guide, and the existing six-topic guide was written before the latest built checkpoint.
What changed
lastcode/checkpoint/v0.1.3-nightly.20261027.3748(2da9a07b51a1878bcbf9066e5c0429df8d7cba8d). Source links point at that exact commit, and the storage, usage-limit and browser explanations are clearer.Validation
463c9ca9d23ec56b87f4885c5d40b7db44a0055fagainst canonical base0e8e29a90015f6bcc9e9dc5544224dc840f0fc6c. Changed-file lint, targeted format check andgit diff --checkpass.Additional validation notes
check:changed origin/lastcode/mainselects the full repository for the HTML file and was interrupted (exit 130) after reporting a format issue that is now fixed. It has not run to completion.Model/harness: GPT-6.1-Sol Extra High in Codex; Astra High review; Claude Opus 5.5 High guide prose pass; Claude Sonnet 5.5 High PR text.