Skip to content

refactor(android): replace kotlinx.serialization with org.json parsing and JsonByteWriter #787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
abelonogov-ld merged 3 commits into from
Oct 2, 2026
Merged

refactor(android): replace kotlinx.serialization with org.json parsing and JsonByteWriter #787

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
57738de
refactor(android): parse JSON responses with org.json instead of kotl…
abelonogov-ld Oct 2, 2026
8161e0f
refactor(android): write JSON with JsonByteWriter and drop kotlinx.se…
abelonogov-ld Oct 2, 2026
71b4423
Merge branch 'main' into feat/android-parse-json-with-org-json
abelonogov-ld Oct 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion sdk/@launchdarkly/observability-android/gradle/libs.versions.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,3 @@

[plugins]
kotlin-android = { id = "org.jetbrains.kotlin.android", version = "2.0.21" }
kotlin-serialization = { id = "org.jetbrains.kotlin.plugin.serialization", version = "2.0.21" }
6 changes: 2 additions & 4 deletions sdk/@launchdarkly/observability-android/lib/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ plugins {

// Apply the Kotlin Android plugin for Android-compatible Kotlin support.
alias(libs.plugins.kotlin.android)
alias(libs.plugins.kotlin.serialization)

// Apply Dokka plugin for documentation generation
id("org.jetbrains.dokka") version "2.1.0"
Expand Down Expand Up @@ -73,9 +72,6 @@ dependencies {
implementation("org.jetbrains.kotlinx:kotlinx-coroutines-core:1.9.0")
implementation("org.jetbrains.kotlinx:kotlinx-coroutines-android:1.9.0")

// Kotlinx serialization for JSON parsing
implementation("org.jetbrains.kotlinx:kotlinx-serialization-json:1.7.3")

// TODO: revise these versions to be as old as usable for compatibility
implementation("io.opentelemetry:opentelemetry-api:1.51.0")
implementation("io.opentelemetry:opentelemetry-sdk:1.51.0")
Expand Down Expand Up @@ -103,6 +99,8 @@ dependencies {
testImplementation("org.junit.jupiter:junit-jupiter")
testRuntimeOnly("org.junit.platform:junit-platform-launcher")

// android.jar only ships org.json stubs, so JVM unit tests need a real implementation.
testImplementation("org.json:json:20260814")
testImplementation("io.mockk:mockk:1.14.5")
testImplementation("org.jetbrains.kotlinx:kotlinx-coroutines-test:1.9.0")

Expand Down
Loading
Loading