Repository navigation
fix(o11y): resync re-sends whole stylesheets when recovering CSS-in-JS rules - #825
Draft
mayberryzane wants to merge 1 commit into
Draft
mayberryzane wants to merge 1 commit into
mayberryzane wants to merge 1 commit into
Conversation
…S rules Bumps the rrweb submodule to b40a4fb (launchdarkly/rrweb#42). When the insertRule patch has been displaced, the stylesheet resync used to re-send only the tail of each grown sheet, which misses rules inserted mid-sheet (styled-components orders rules by component) and duplicates shifted ones. It now replaces the replayer's copy of the sheet. Also picks up launchdarkly/rrweb#39, which is replay-side and inert for the recorder bundles these packages ship. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps the rrweb submodule to b40a4fb (launchdarkly/rrweb#42). When recording recovers CSS-in-JS rules after another script displaced its
insertRulepatch, it now re-sends the whole stylesheet instead of its tail, so rules inserted mid-sheet (styled-components) reach the replay instead of being lost.The README note in
sdk/@launchdarkly/o11y/gives release-please a path to attribute a patch release to@launchdarkly/o11y; its dependents follow via the node-workspace plugin. Also picks up launchdarkly/rrweb#39, which is replay-side and inert for the recorder bundles. No dependency changes in the bumped range.🤖 Generated with Claude Code