Skip to content

chore(docs): Note rejected SDK key retry in the initialization matrix row - #68

Merged
kinyoklion merged 1 commit into
mainfrom
devin/1791384372-readme-rejected-key-init
Oct 13, 2026
Merged

kinyoklion merged 1 commit into
mainfrom
devin/1791384372-readme-rejected-key-init

Conversation

@kinyoklion

@kinyoklion kinyoklion commented Oct 7, 2026 •

Copy link
Copy Markdown
Member

Summary

LaunchDarkly Python SDK 9.18.0 made a rejected SDK key retryable rather than permanently stopping the data source. The README says start_wait=0 waits "until the data source becomes valid or permanently fails", but a rejected key now never permanently fails. With zero, initialize therefore never completes while the key is rejected.

  • Initialization row: now ⚠️, notes the SDK 9.18.0 behavior, and marks the provider gap (zero should mean "do not wait", per OFP 4.3.6), tracked by #64.
  • The start_wait paragraph gets the same note.
Details

I checked this locally with launchdarkly-server-sdk 9.18.1 and an invalid key. The data source stayed INITIALIZING, and last_error reported ERROR_RESPONSE 401 while it retried. It never reported OFF.

The provider allows launchdarkly-server-sdk >=9.17.0,<10, so new installs get the retry behavior. #64 also edits these lines. Whichever merges second will need a small README conflict fix.

Found in the weekly OpenFeature provider audit. Docs-only change.

Link to Devin session: https://app.devin.ai/sessions/c8bc4e80339b473882c2dddffe981edf
Open in Devin Desktop: https://app.devin.ai/desktop/session/c8bc4e80339b473882c2dddffe981edf?variant=devin
Requested by: @kinyoklion

SDK-3286


Note

Overview
Updates README to reflect LaunchDarkly Python SDK 9.18.0+ behavior: a rejected SDK key is retried instead of permanently failing the data source.

The Initialization feature matrix row is downgraded from ✅ to ⚠️, with notes that start_wait=0 can wait indefinitely on a bad key and that the provider still has a gap (zero should mean “do not wait” per OpenFeature), linked to #64. The start_wait getting-started paragraph adds the same SDK 9.18.0 caveat so it matches the matrix.

Reviewed by Cursor Bugbot for commit 4b2f0cc. Bugbot is set up for automated code reviews on this repo. Configure here.

Co-Authored-By: rlamb@launchdarkly.com <4955475+kinyoklion@users.noreply.github.com>
@devin-ai-integration

Copy link
Copy Markdown
Contributor

I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".

  • Disable automatic comment, CI, and merge conflict monitoring

@kinyoklion kinyoklion changed the title docs: Note rejected SDK key retry in the initialization matrix row chore(docs): Note rejected SDK key retry in the initialization matrix row Oct 12, 2026
@kinyoklion
kinyoklion marked this pull request as ready for review October 12, 2026 20:11
@kinyoklion
kinyoklion requested a review from a team as a code owner October 12, 2026 20:11
@kinyoklion
kinyoklion merged commit 5a890fc into main Oct 13, 2026
10 checks passed
@kinyoklion
kinyoklion deleted the devin/1791384372-readme-rejected-key-init branch October 13, 2026 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants