Repository navigation
fix: bump nanoid to ^5.1.16 and vitest to ^4.1.11 (dependency vulnerabilities) - #40
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
…cy vulnerabilities Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Contributor
Author
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dependency vulnerability fixes (automated)
Generated by the Devin Dependency Security Vuln Fix automation run on 2026-10-05 (first opened 2026-09-28).
Change type: Major version bump(s), manifest/lockfile only.
Warning
We're not just looking for a review like a normal PR. Security can offer this fix as a recommendation, but doesn't have the tooling or domain knowledge to safely verify changes like this end-to-end for each repo. Please review, test, and own deployment before merging. For more information: https://launchdarkly.atlassian.net/wiki/spaces/SEC/pages/5360943572/Dependency+Vulnerability+Remediation+with+Devin.
Findings addressed
packages/web-extension)Notes for reviewers:
/yarn.lockis gitignored and the lockfile is owned bylaunchdarkly/observability-sdk), so this PR only changes manifests. A fresh install resolves nanoid 5.1.16 and vitest 4.1.11.vitestays on^6.4.2, since vitest 4.1.11 supports vite 6, 7 and 8.web-extensiononly uses the namednanoidexport in ESM/Vite code, and the extension builds.nanoidline. That PR sets^5.1.11, which leaves the manifest floor inside alert #95's vulnerable range (< 5.1.16). Whichever PR merges second needs a trivial conflict fix.^4.1.8, which is still inside the< 4.1.11vulnerable range, and it also bumps vite to 8.vitest.workspace.tsusesdefineWorkspace, which vitest 4 removed. No script references the file, because each package runs its ownvitest.config.tsvia turbo, so it was left untouched.main, so no new commits were needed.Deferred / excluded findings
packages/rrweb-player) ^4.2.14 → 5.55.7, Medium, 227d (Dependabot #52–#55, #75, #76; GHSA-crpf-4hrx-3jrp, GHSA-f7gr-6p89-r883, GHSA-m56q-vw4c-c2cp, GHSA-phwv-c562-gvmh, GHSA-pr6f-5x2q-rwfp, GHSA-rcqx-6q8c-2c42). Fully fixed by Dependabot chore(deps): bump the npm_and_yarn group across 2 directories with 2 updates #32 (^5.56.3), which has green CI.packages/web-extension, viareact-router-dom) 6.30.6 → 7.18.4, Medium, Wiz only (CVE-2026-53666, CVE-2026-53669). See fix: bump react-router-dom to ^7.18.0 in web-extension (dependency vulnerabilities) #41.Verification
Installed, built and linted again on 2026-10-05:
yarn install. The only failure ispackages/rrvideo's Playwright browser postinstall, which can't reach the Playwright CDN from the automation sandbox. This happens onmaintoo.yarn build:allpasses 22/22. Locally,web-extension's manifest schema validation had to be skipped because the sandbox can't fetch the schema.TestsandWebKit (Safari engine) testspass on this head commit. The 2026-09-28 sandbox run showed no regressions againstmain. The only failures were network/browser tests, and the same tests fail onmain.yarn linthas no new errors. The only errors are the same 3rrweb-player.svelteparser errors as onmain.yarn check-typespasses 34/34.Link to Devin session: https://app.devin.ai/sessions/7ce588b86a7c4694bdf0e030b6812b06
Open in Devin Desktop: https://app.devin.ai/desktop/session/7ce588b86a7c4694bdf0e030b6812b06?variant=devin
Note
Overview
Addresses dependency advisories with manifest-only version bumps—no application source changes.
vitest is raised from
^3.2.6to^4.1.11in eleven workspace packages (all,browser-client,packer, console/network record plugins,record,replay,rrdom,rrdom-nodejs,rrweb-snapshot,rrweb). That is a major devDependency upgrade for the test runner (GHSA-82fw-gwwq-j7x9);vitestays on^6.4.2, which vitest 4 supports.nanoid in
packages/web-extensionmoves from^4.0.0to^5.1.16(runtime dependency for ID generation in background/session code via ESMimport { nanoid }). nanoid 5 is ESM-only; the extension already uses that pattern under Vite.Lockfiles are not committed in this repo, so consumers must reinstall to pick up resolved versions.
Reviewed by Cursor Bugbot for commit 44a6b7e. Bugbot is set up for automated code reviews on this repo. Configure here.