Skip to content

chore: Wait for the replacement flag in the FDv1 fallback spec #457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jsonbailey merged 2 commits into from
Oct 5, 2026
Merged

chore: Wait for the replacement flag in the FDv1 fallback spec #457

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2261259
chore: Wait for the replacement flag in the FDv1 fallback spec
jsonbailey Oct 2, 2026
560eb1b
chore: Drop the comment restating the gate condition
jsonbailey Oct 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions spec/impl/data_system/fdv2_datasystem_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -441,12 +441,12 @@ def with_data_system(initializers, synchronizers)
.build

changed = Concurrent::Event.new
changes = []
changes = Concurrent::Array.new

listener = Object.new
listener.define_singleton_method(:update) do |flag_change|
changes << flag_change
changed.set if changes.length >= 2
changed.set if flag_change.key == "fdv1replacementflag"
end

fdv2 = FDv2.new(sdk_key, config, data_system_config)
Expand Down
Loading