Skip to content

fix(UserSearchField): extract key prop from renderOption spread#1625

Draft
Sbragul26 wants to merge 2 commits into
layer5io:masterfrom
Sbragul26:fix/usersearchfield-key-prop
Draft

fix(UserSearchField): extract key prop from renderOption spread#1625
Sbragul26 wants to merge 2 commits into
layer5io:masterfrom
Sbragul26:fix/usersearchfield-key-prop

Conversation

@Sbragul26

Copy link
Copy Markdown
Member

Notes for Reviewers

This PR fixes #1624 . It fixes the failing hideRootObjectTitle test by ensuring the expected title is returned.
All tests are passing successfully.

Test Results

image

Signed commits

  • Yes, I signed my commits.

Signed-off-by: Sbragul26 <sbragul26@gmail.com>

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates a test assertion in "hideRootObjectTitle.test.tsx" to reflect the canonical import-design root title behavior, and modifies "UserSearchFieldInput.tsx" to destructure and apply a key to the list item in "renderOption". The reviewer recommends using the internally generated "key" from MUI's "props" in "renderOption" instead of "option.userId" to ensure proper compatibility and accessibility.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread src/custom/UserSearchField/UserSearchFieldInput.tsx Outdated
@Sbragul26 Sbragul26 marked this pull request as draft June 12, 2026 19:40
Signed-off-by: Sbragul26 <sbragul26@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] hideRootObjectTitle test fails - root title returns empty string

1 participant