fix(UserSearchField): extract key prop from renderOption spread#1625
fix(UserSearchField): extract key prop from renderOption spread#1625Sbragul26 wants to merge 2 commits into
Conversation
Signed-off-by: Sbragul26 <sbragul26@gmail.com>
There was a problem hiding this comment.
Code Review
This pull request updates a test assertion in "hideRootObjectTitle.test.tsx" to reflect the canonical import-design root title behavior, and modifies "UserSearchFieldInput.tsx" to destructure and apply a key to the list item in "renderOption". The reviewer recommends using the internally generated "key" from MUI's "props" in "renderOption" instead of "option.userId" to ensure proper compatibility and accessibility.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Signed-off-by: Sbragul26 <sbragul26@gmail.com>
Notes for Reviewers
This PR fixes #1624 . It fixes the failing hideRootObjectTitle test by ensuring the expected title is returned.
All tests are passing successfully.
Test Results
Signed commits