Skip to content

[fork-CI] [20.0] sdpo: styling requested by pilarvargas on OCA/spreadsheet#133 - #10

Open
dnplkndll wants to merge 12 commits into
20.0from
20.0-sty-sdpo
Open

dnplkndll wants to merge 12 commits into
20.0from
20.0-sty-sdpo

Conversation

@dnplkndll

@dnplkndll dnplkndll commented Oct 22, 2026 •

Copy link
Copy Markdown

Styling for OCA#133, with the original layout preserved. Proposed content for the [MIG] commit — not pushed upstream.

What pilarvargas reported

The version currently on OCA#133 (comment) "threw off the sizing of the top KPI cards" and changed "the layout of the other tables". She was right: that build moved the KPI row from 5-across at 200px to 3-across at 325px, and moved the tables from the original wide-left / narrow-right arrangement to full-width plus two-up. She asked for styling, not a new layout.

This branch

Every figure sits on the measured geometry of the pre-styling dashboard (166c1f9):

x y w h
KPI cards 9 / 218 / 427 / 636 / 845 9 200 108
Top Vendors by Amount 9 178 1035 230
Top Orders 9 431 650 655
Sourcing by Country 711 431 336 310
Top Vendors 711 764 336 322
Top Products 9 1109 650 322
Top Buyers 711 1109 336 322

So the only visible difference from the original is the styling that was asked for: white KPI cards with teal titles, and a white card wrapping each section's title and content.

One adaptation: card titles in the 336px right-hand column render at 16px rather than 21px, otherwise "Sourcing by Country" truncates to "Sourcing by C…".

Why the diff is still ~1100 lines

The white section card is a carousel figure — core 20.0's own mechanism — and a carousel's data view reads a range on a separate sheet. So the tables move to their own sheets behind a spilling formula, and the payload has to be migrated 18.5.10 → 19.3.10 first (step 19.3.10 renames the spilling ODOO.LIST otherwise). Those are consequences of the approach, not bundled extras: stripping everything optional changed 5 numbers.

If that is too much churn for a migration, the alternative is a flat white fillColor behind each section — ~30 lines, but white rectangles rather than a card, and the empty-row blocks stay.

Follow-up features remain stacked in #11.

AI-assisted (Claude Code); every change reviewed, tested, and owned by the author.

Odoo and others added 11 commits September 28, 2026 11:29
Copied as is from Odoo 17.0 branch. Later commits will do the needed
changes.
Currently translated at 100.0% (27 of 27 strings)

Translation: spreadsheet-18.0/spreadsheet-18.0-spreadsheet_dashboard_purchase_oca
Translate-URL: https://translation.odoo-community.org/projects/spreadsheet-18-0/spreadsheet-18-0-spreadsheet_dashboard_purchase_oca/it/
Currently translated at 100.0% (27 of 27 strings)

Translation: spreadsheet-18.0/spreadsheet-18.0-spreadsheet_dashboard_purchase_oca
Translate-URL: https://translation.odoo-community.org/projects/spreadsheet-18-0/spreadsheet-18-0-spreadsheet_dashboard_purchase_oca/fr/
Currently translated at 100.0% (31 of 31 strings)

Translation: spreadsheet-19.0/spreadsheet-19.0-spreadsheet_dashboard_purchase_oca
Translate-URL: https://translation.odoo-community.org/projects/spreadsheet-19-0/spreadsheet-19-0-spreadsheet_dashboard_purchase_oca/it/
Signed-off-by: Don Kendall <dkendall@ledoweb.com>
Assisted-by: Claude Code
* data/dashboards.xml: payload loads with type="bytes", not type="base64".
* vendors_dashboard.json: Dashboard sheet backgroundColor #F9FAFB, as core.

Signed-off-by: Don Kendall <dkendall@ledoweb.com>
Assisted-by: Claude Opus 5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants