Conversation
leejet
requested changes
Sep 13, 2026
fszontagh
force-pushed
the
feat/llada-image
branch
2 times, most recently
from
September 13, 2026 17:19
c1e7233 to
f642157
Compare
fszontagh
marked this pull request as draft
September 13, 2026 18:05
fszontagh
force-pushed
the
feat/llada-image
branch
2 times, most recently
from
September 14, 2026 16:28
146b53f to
7a19970
Compare
Contributor
Author
|
Both done: Since the merge script is gone, I converted the weights for both checkpoints and uploaded them, so the docs link ready-made files instead of asking people to build their own. Links are in |
fszontagh
marked this pull request as ready for review
September 14, 2026 18:41
fszontagh
force-pushed
the
feat/llada-image
branch
from
September 14, 2026 20:57
7a19970 to
f470c7d
Compare
Contributor
Author
|
Rebased on master and dropped the embedded vocab, following #1974. LLaDA2 now needs Output is pixel-identical to the old embedded-vocab build. Updated the PR description too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds text-to-image and instruction-guided editing for LLaDA-Image (Apache-2.0): a 6B Lumina2/Z-Image-style NextDiT conditioned by a LLaDA2-MoE diffusion-LLM text encoder, reusing the Flux.2 VAE.
Most of it reuses what is already here. The DiT instantiates
ZImage::JointTransformerBlockandFinalLayerwith identical hyperparameters, and the text encoder is a newLLMArch::LLADA2_MOEon the existing MoE path. New are the QueryFormer, the text projection, and SigVQ for editing, plus thellada_imagereference-image preset and sigma schedule. Editing runs the clean reference and the noisy target in one sequence; adaLN is linear in the timestep embedding, so feeding a per-token embedding selects the right modulation without new modulation machinery.The LLaDA2 vocabulary is not embedded, so
--tokenizerwith the model'stokenizer.jsonis required, per the embedded-data allowlist inCONTRIBUTING.md.One change outside the model:
tensor_should_be_convertednow skips*_pad_token. LLaDA-Image stores those around 7.7e24, which overflows both f16 storage and q8_0's f16 block scale, so every converted GGUF rendered blank white without it.Docs in
docs/llada_image.md; rows added toREADME.mdanddocs/edit.md.Related Issue / Discussion
Closes #1937
Additional Information
Verified on an RTX 3060 12GB, CUDA. Both checkpoints work: LLaDA-Image-Turbo does text-to-image and editing at 512x512 and 1024x1024, and the 50-step base model at
--steps 50 --cfg-scale 5does both at 1024x1024. At 512x512 the base model's editing returns the reference almost unchanged, which the docs note.--max-vram 6,--max-vram 4and--max-vram 3all produce byte-identical output to unconstrained execution.Not implemented:
generation_mode="vq", where the text encoder block-diffusion-decodes VQ tokens before diffusion. Text-to-image and editing do not use that path.Checklist