Repository navigation
Build the rate-limit test's response on hf-hub's own HTTP library - #226
Merged
Merged
Conversation
huggingface-hub 2.0 moved from httpx to httpx2, and the daily fresh dependencies job has failed since 2026-10-09 on the one test that built an httpx response by hand. The engine itself runs unchanged on 2.x.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
liverun has failed since 2026-10-09, every time in fresh dependencies (notifies) and on one test:test_hf_rate_limit_keeps_the_job_waitingbuilt anhttpx.Responseby hand, and huggingface-hub 2.0 (now 2.2.0, which every instance resolves) dropped httpx for httpx2, soimport httpxfails.HfHubHTTPErroris built on, so it runs on hf-hub 1.x (the lock) and 2.x (what instances run).huggingface_hub.errors.HfHubHTTPErrorstill exists and is still anOSError,try_to_load_from_cacheimports, and faster-whisper 1.2.1'ssnapshot_downloadkwargs all still match the 2.2.0 signature.Test plan
--with huggingface-hub==2.2.0(confirmed the overlay ran 2.2.0 / httpx2): 17 passed eachuv run pytest -m "not live"(4758 passed),ruff check,ty check,ruff format --check .live.ymldispatched on this branch: run 38412584202