fix: support LAN browser UUIDs and document Generic control ownership - #25
Open
why-tomato wants to merge 2 commits into
Open
fix: support LAN browser UUIDs and document Generic control ownership#25why-tomato wants to merge 2 commits into
why-tomato wants to merge 2 commits into
Conversation
|
Claude finished @why-tomato's task in 1m 10s —— View job 任务清单
Review 结论有条件通过 问题及建议
未发现会影响合并的代码正确性或 secret 泄露问题——本 PR 仅修改 |
|
Claude finished @why-tomato's task in 3m 5s —— View job 任务清单
Review 结论有条件通过 问题及建议
其他说明
残余风险:P1 项主要影响可维护性和评审可信度,非明确的运行时 bug;P2 项均为非阻塞的健壮性/清理建议。 |
|
Claude finished @why-tomato's task in 2m 19s —— View job 任务清单
Review 结论有条件通过 问题及建议
其余部分( |
Author
Review 处理结论
当前没有已确认需要阻塞合并的 P0/P1。PR head 保持 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
room_video,最终回到 Browser。0.0.0.0:4003的云侧前端,并提供云侧、Orin、真实静态资源及浏览器手动验收步骤。crypto.randomUUID不可用时,在 Room hooks 运行前安装一个基于crypto.getRandomValues的 RFC 4122 v4 UUID 回退实现;Browser Session ID 也复用同一生成逻辑。send(message)发送链路。运行时变更范围
components/app/session-provider.tsx:在创建 Room 相关 Provider 前初始化 UUID 兼容逻辑;如果浏览器连安全随机数能力也不具备,则显示明确的兼容性错误。lib/browser-room-session.ts:新会话 ID 改用浏览器安全的 UUID 生成函数。lib/browser-runtime-compat.ts:在不覆盖浏览器原生实现的前提下安装randomUUID回退。tests/browser-room-session.test.mjs和tests/browser-runtime-compat.test.mjs:覆盖原生实现、回退实现、已有 Session ID 复用、安装失败、Provider 执行顺序及聊天发送链路未改变。README.md:记录 Generic 所有权边界和 Orin 访问云侧 UI 的部署与验收方法。所有权边界
8013端口。EDGE_MEDIA_URL管理。/start和/stop调用仍由 LexVoice Generic Agent 负责。room_audio和room_video_raw;LexVoice Video Processor 发布room_video。codex/endpoint-connectivity-probe分支和 PR feat: orchestrate Generic endpoints through heartbeat leases #23 保持不变,作为技术存档。验证结果
origin/lex-main共修改 6 个文件:README.md、3 个运行时文件和 2 个测试文件。npm run format:check:通过。npm run lint:通过。npm run test:253 项全部通过。npm run build:通过。841b0fb261f00db80da8317d3701c5be2cd700d9。项目的
pnpm启动器在受限环境中无法校验或下载锁定版本,因此使用现有本地依赖,通过npm run执行了相同的package.json脚本。