Keep documentation sidebar links within the selected port - #59
Merged
Merged
Conversation
why: Root builds also render owned port pages. Their shared sidebar links used the build context and sent readers to general documentation. what: - Build sidebar URLs from the page port and version - Cover both sidebar copies at desktop and phone widths, including Python stable and TypeScript latest - Prove the browser assertion fails with the original URL builder Validation: pnpm test passed in 47.81 seconds.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From a TypeScript page rendered by the root build, “Filtering and queries” linked to
/en/concepts/queries/even though the TypeScript page exists. Sidebar links now use the page’s selected port and version through the existing URL helper.The browser check covers desktop and mobile sidebars on TypeScript latest and Python stable pages. It fails against the old builder with the reported URL mismatch.
pnpm testpasses in 47.81 seconds; publication checks remain separate.