Conversation
why: Provide captured tmux values, explicit effects, bounded async work, and stream adaptation without duplicating the Java engine. what: - Publish core and optional core.async Clojure modules through the BOM. - Add captured snapshots, bounded tasks, control streams, and byte events. - Test owned real-tmux fixtures, documentation fences, artifacts, and Clojure boundary contracts.
why: Match the repository Java formatter. what: - Wrap group failure assertions in the standard layout.
why: Task completion can publish before the virtual worker stops. what: - Join the owned fixture worker before asserting its cleanup.
why: macOS resolves fixture socket paths through /private/tmp while tmux preserves the original /tmp spelling in its command arguments. what: - Match sockets by their resolved paths during ownership checks. - Cover ancestor-link aliases and control-process ownership.
why: Captured values can outlive a client, while capture I/O must finish within the server's resource scope. what: - Add an executable lazy traversal and eager capture example. - Check the capture count in the documentation test.
why: Window auto-renaming races shell startup on macOS, making the false-condition test report an unrelated title change as an effect. what: - Assert a private option that only the guarded command can change. - Remove the fixed delay and window-title dependency.
why: Cancellation publishes the terminal outcome asynchronously. what: - Observe the cancelled task before resubmission - Remove the JDK 25 admission timing race
why: Fixture scanning conflated a tmux client with its daemon. what: - Read the authenticated daemon PID from tmux - Cover concurrent client ownership
why: Client operations need live evidence that preserves the captured target. what: - Attach an owned control client in the Clojure integration fixture - Assert switch and detach through refreshed client observations
why: Closing a runtime could test completion-executor quiescence before its queued callback cancellations ran. what: - Snapshot callback stages and await their scheduled cancellation - Keep the wait within the runtime's existing cleanup deadline - Record the caller-visible close behavior in the changelog
why: A labeled matrix cannot establish Clojure compatibility unless the selected runtime and tmux binary are verified by the process under test. what: - Add four Clojure/JDK check and package cells - Add forty Linux and eight macOS Clojure real-tmux cells - Assert the Clojure runtime selected for each integration run
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
libtmux-clojurewith captured values, explicit tmux effects, local collection processing, bounded tasks, and owned control streams.libtmux-clojure-core-asyncwithout adding core.async to the core module.CompletionStagerecipe.Design decisions
FilterExprinterop, while ordinary Clojure maps and collections handle local work.Test plan