CI: Build the Java docs with the current docs assembly - #36
Merged
Merged
Conversation
why: libtmux.org's Java pages lacked the Ruby and Lua entries every other port's pages show. This repository builds its tree with libtmux/docs's own assembly, pinned to a commit from before Ruby and Lua joined the site (libtmux/docs#18), so each push to master rebuilt the Java pages with the old menu. what: - Pin the docs checkout and the reusable deploy workflow to the current libtmux/docs commit, together, as the workflow requires - Built locally at each pin, the Java landing page links Ruby and Lua three times each at the new one and not at all at the old
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Compatibility
scripts/build-site.sh --ports java --skip-pagefindwithLIBTMUX_DOCS_CHECKOUT_JAVAstill works; the script's new source-bound mode switches on only when its own variables are set.path-prefix,artifact,version-kind,port,version,is-default,environmentand the three secrets all still exist inreusable-deploy.yml.Test plan
docsworkflow publishes from master after merge