fix(catalog): correct the native GPT-5.6 context window to 272k - #1648
fix(catalog): correct the native GPT-5.6 context window to 272k#1648waw4303 wants to merge 1 commit into
Conversation
The upstream models.json advertises 372k for the GPT-5.6 family, but the effective Codex OAuth contract is 272k. Align NATIVE_GPT56_CONTEXT_WINDOW (and Daybreak Blue, which inherits Sol capabilities) with the 272k standard already used for gpt-5.5, so catalog rows and auto-compact limits stop overstating native capacity.
|
✅ Deterministic PR hygiene checks passed. |
|
Important Review skippedNo new commits to review since the last review. ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThe native GPT-5.6 context window changes from 372,000 to 272,000 tokens. Catalog synchronization and catalog tests update related context, maximum-context, and auto-compaction expectations. ChangesGPT-5.6 context window
Estimated code review effort: 1 (Trivial) | ~5 minutes Mergeability Score: ⚪ Minimal · up to This change corrects the native GPT-5.6 context limit and its derived compaction limit, with targeted tests and typechecking passing; no actionable merge-blocking risk remains. Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
⏳ DRAFT
What to do
Review readiness checklist
2/4 boxes ticked. This PR stays in draft until every box above is ticked. |
|
Tip For best results, initiate chat on the files or code changes.
🧠 Learnings usedYou are interacting with an AI system. |
|
🧠 Learnings used
|
|
this is I intended |
PR description: fix(catalog): correct the native GPT-5.6 context window to 272k
Summary
Align the native GPT-5.6 catalog rows with the real Codex OAuth contract. The upstream
models.jsonadvertises372_000for the GPT-5.6 family, but the effective context for Codex OAuth sessions is the272_000standard already used for gpt-5.5. This changesNATIVE_GPT56_CONTEXT_WINDOWfrom372_000to272_000, sogpt-5.6-sol/terra/lunaand account-scoped Daybreak Blue (which inherits Sol capabilities) stop overstating native capacity; the derivedauto_compact_token_limitfollows automatically (floor(window * 0.9)→ 244_800).src/codex/catalog/metadata.ts— constant corrected.tests/codex-catalog.test.ts,tests/codex-catalog-sync-hardening.test.ts— assertions that flow throughnativeOpenAiContextWindow/applyNativeOpenAiContextOverrideupdated to 272_000/244_800. Upstream-snapshot assertions (the raw pinnedmodels.jsonvalues) are intentionally untouched.Verification
bun test tests/codex-catalog.test.ts— 176 pass / 0 fail.bun test --timeout 60000 tests/codex-catalog-sync-hardening.test.ts— 25 pass / 0 fail (the three spawn-heavy cases need the CI-style 60s timeout, not Bun's 5s default).bun run typecheck— pass.Checklist
Review readiness checklist
This PR stays in draft until every box below is ticked. Tick all four boxes once the requirements are met:
All CI tests are green on my local testing.
I pushed my PR to the latest dev commit.
I resolved all correct Codex and CodeRabbit findings.
My PR is ready for review.
Summary by CodeRabbit