rebalance: support custom CLN version strings#891
Draft
bittylicious wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getroutesschema from the returned route fieldsBackground
Core Lightning exposes its build identifier verbatim through
getinfo.version, so custom builds may return a branch or package name instead of a release such asv26.06.2. The rebalance plugin currently parses that value as dotted integers during initialization, which raisesValueErrorand leaves the plugin only partially initialized.This change treats an unparseable identifier as an unknown release version. Route handling no longer needs that release number: it detects the pre-26.06 or 26.06+ schema from the actual
getroutespath. Parseable versions older thanv25.09are still rejected as before.Compatibility
The repository CI matrix runs the rebalance integration tests against CLN
25.12,26.04, and26.06.1on Python 3.10 and 3.12, covering both route schemas. An opaque build identifier necessarily skips only the startup release-number check; unavailable RPCs still fail normally when called.Tests
pytest -q rebalance/test_clnutils.py(7 passed)ruff checkandruff format --checkpython3 -m py_compilegit diff --check