Wait for splice broadcasts before mining - #1046
Merged
Merged
Conversation
SpliceNegotiated only marks negotiation's end. The asynchronous broadcast may still be queued, so immediate mining can leave the splice short of the confirmations required for ChannelReady. Wait until each negotiated transaction is observable before mining in the affected lifecycle, balance, and interop tests. Co-Authored-By: HAL 9000
|
👋 Thanks for assigning @jkczyz as a reviewer! |
jkczyz
approved these changes
Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SpliceNegotiatedonly marks negotiation's end. The asynchronous broadcast may still be queued, so immediate mining can leave the splice short of the confirmations required forChannelReadyWait until each negotiated transaction is observable before mining in the affected lifecycle, balance, and interop tests.
This should make tests a little less flaky