Fix RTAS detection logic in catalog - #699
Open
jiang95-dev wants to merge 2 commits into
Open
Conversation
| // only place where RTAS is unambiguously known: by the time doCommit runs, a replace and an | ||
| // ordinary metadata-plus-snapshot transaction look identical. Every Catalog replace entry | ||
| // point (including Catalog#newReplaceTableTransaction) funnels through this builder. | ||
| ((OpenHouseTableOperations) ops).markReplaceTransaction(); |
Contributor
There was a problem hiding this comment.
Why are we casting? either this takes in OpenhouseTableOperations always or this will result in a bad cast exception and using the generic TableOperations was not useful.
Collaborator
Author
There was a problem hiding this comment.
Yes it's better to always use OpenHouseTableOperations in OpenHouseCatalog.
jiang95-dev
force-pushed
the
lejiang/rtas-transaction
branch
from
August 27, 2026 20:39
07e55df to
95f2b56
Compare
| } | ||
|
|
||
| // ============================= OpenHouse Views (gated, off by default) ============================= | ||
| // ============================= OpenHouse Views (gated, off by default) |
Contributor
There was a problem hiding this comment.
why did this file change?
Collaborator
Author
There was a problem hiding this comment.
It's due to style check.
jiang95-dev
force-pushed
the
lejiang/rtas-transaction
branch
from
August 28, 2026 01:05
a170414 to
88985f8
Compare
added 2 commits
August 27, 2026 19:37
jiang95-dev
force-pushed
the
lejiang/rtas-transaction
branch
from
August 28, 2026 02:37
88985f8 to
10b257e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Currently TableOps recognize an RTS operation by
isPutSnapshot && isMetadataUpdate && base != null. This is wrong since a transaction containing snapshot and metadata update is totally valid without being an RTAS operation. Adding a flag in TableOps and passing it from Catalog to recognize RTAS.Changes
For all the boxes checked, please include additional details of the changes made in this pull request.
Testing Done
For all the boxes checked, include a detailed description of the testing done for the changes made in this pull request.
Additional Information
For all the boxes checked, include additional details of the changes made in this pull request.