Repository navigation
fix: wait for running tasks after first failure - #199
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
runTasksWithLimit()now records the first error and stops new task dispatch.It waits for all started tasks before it rejects.
Tests cover blocked tasks, stopped dispatch, and first error propagation.
Why
Promise.all()returned on the first failure while other tasks still ran.This could make
batchLint()destroy its pool before tasks ended.It could also make
runFileLint()report a write failure before other writes ended.Verification
npm run lintpassed.npm test -- --runInBandpassed: 26 suites and 226 tests.git diff --checkpassed.Redactions
No sensitive data was included.
Closes #198