Repository navigation
fix(cli): fail on remaining diagnostics after --fix - #202
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Keep Core's
remainingSummaryinBatchLintItem.Use the remaining error and warning counts to decide the
--fixexit code.Check every file result, including results excluded from writeback.
Fail if a file fix result lacks remaining counts.
Keep stdin output as Markdown only.
Print each file's remaining error and warning counts to stderr.
Print the same summary to stderr for stdin input.
Why
--fixcould return exit code 0 while errors or unsuppressed warnings remained.The previous check only handled rule execution errors.
Verification
npm run lintpassed.npm test -- --runInBandpassed: 27 suites and 238 tests.git diff --cached --checkpassed.Redactions
No sensitive data was included.