Repository navigation
feat(edit): replace file selection icon and adjust button layout - #730
Conversation
Reviewer's GuideThis PR adds a Qt6-only embedded 16×16 file-selection icon and selects its resource bundle during Qt6 builds, while updating all Qt6 edit-control examples so the file button is right-aligned with consistent 16px sizing and 8px spacing relative to the clear button; Qt5 resources remain unchanged. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
1. Replace built-in entry_loadfile DCI with a new 16x16 icon 2. Set file selection button icon size to 16px in Qt6 exhibition example 3. Move file selection button to rightmost position with 8px spacing Log: Replace file selection icon and adjust button layout in exhibition example Influence: File selection shows new icon with consistent size and spacing feat(edit): 替换文件选择图标并调整按钮布局 1. 替换内置 entry_loadfile DCI 为新的 16x16 图标 2. 在 Qt6 exhibition 示例中设置文件选择按钮图标尺寸为 16px 3. 将文件选择按钮移至最右侧,间距为 8px Log: 替换文件选择图标并调整 exhibition 示例中的按钮布局 Influence: 文件选择显示新图标,尺寸和间距保持一致
44bd6e2 to
bcaa58e
Compare
deepin pr auto review🤖 AI 代码审查报告📊 总体评价
🔍 详细分析1. 语法逻辑 ✅评价: 语法正确,逻辑清晰 ✅ 通过 潜在问题: 建议: 无 2. 代码质量 ✅评价: 代码结构清晰,注释完整 ✅ 通过 潜在问题: 建议: 无 3. 代码性能 ✅评价: 性能良好,资源使用合理 ✅ 通过 潜在问题: 建议: 无 4. 代码安全 🔒评价: 存在0个安全漏洞 ✅ 通过
安全漏洞详情: 建议: 无 💡 改进建议代码示例本次变更无需修复,代码已符合规范。以下为当前实现的正确写法参考:
```qml LineEdit {
id: keyLineEdit
width: Math.max(implicitWidth, editInputMinWidth)
text: "~/.ssh/ssh_keygen.key"
clearButton.anchors.rightMargin: fileBtn1.width + 8
ActionButton {
id: fileBtn1
anchors {
right: parent.right
rightMargin: 8
verticalCenter: parent.verticalCenter
}
width: height
icon.name: "entry_loadfile"
icon.width: 16
icon.height: 16
onClicked: {
keyFileDialog.open()
}
}
} ```本报告由 AI 代码审查工具自动生成 |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 18202781743, iCancely The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
81df4a4
into
linuxdeepin:v25-flowstyle
Summary / 概述
Replace the built-in
entry_loadfileDCI icon with a new 16x16 version, and adjust the file selection button layout in the Qt6 exhibition example: icon size 16px, rightmost position, 8px spacing, consistent with clear and echo button layout.直接替换内置的
entry_loadfileDCI 图标为新的 16x16 版本,并调整 Qt6 exhibition 示例中文件选择按钮的布局:图标尺寸 16px、移至最右侧、间距 8px,与清除按钮和密码显示按钮布局保持一致。Changes / 变更内容
Replace
src/icons/bloom/entry_loadfile.dciwith the new 16x16 icon (955 bytes -> 810 bytes)Update
examples/exhibition/qt6/EditControl.qml:替换
src/icons/bloom/entry_loadfile.dci为新的 16x16 图标(955 字节 -> 810 字节)更新
examples/exhibition/qt6/EditControl.qml:Test / 测试
Rebuilt
dtk6-exhibitionand verified the new icon renders correctlyConfirmed the icon is embedded in the binary (no runtime dependency on local files)
Verified button layout: file button rightmost, clear button to its left, both 8px spacing
重新构建
dtk6-exhibition,验证新图标正常显示确认图标已嵌入二进制文件(运行时不依赖本地文件)
验证按钮布局:文件按钮在最右侧,清除按钮在其左侧,间距均为 8px