Skip to content

Update nlohmann_json package - #218

Merged
TheAssassin merged 1 commit into
linuxdeploy:masterfrom
meator:pr/update-nlohmann_json
Aug 21, 2026
Merged

Update nlohmann_json package#218
TheAssassin merged 1 commit into
linuxdeploy:masterfrom
meator:pr/update-nlohmann_json

Conversation

@meator

@meator meator commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

This PR fixes the following configure error when using nlohmann_json provided by CMake:

CMake Error at /tmp/linuxdeploy-plugin-qt-build-plmioK/_deps/nlohmann_json-src/CMakeLists.txt:1 (cmake_minimum_required):
  Compatibility with CMake < 3.5 has been removed from CMake.

  Update the VERSION argument <min> value.  Or, use the <min>...<max> syntax
  to tell CMake that the project requires at least <min> but has been updated
  to work with policies introduced by <max> or earlier.

  Or, add -DCMAKE_POLICY_VERSION_MINIMUM=3.5 to try configuring anyway.

v3.10.4 fails to configure with newer CMake because it used some
deprecated features.

@TheAssassin TheAssassin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! If CI agrees, let's merge this.

@TheAssassin
TheAssassin merged commit 3808b01 into linuxdeploy:master Aug 21, 2026
6 checks passed
@meator
meator deleted the pr/update-nlohmann_json branch August 22, 2026 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants