Skip to content

Fix qmlimportscanner lookup #219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TheAssassin merged 2 commits into from
Aug 22, 2026
+20 −12
Merged

Fix qmlimportscanner lookup #219

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7c2662d
Fix redundant QmlImportScanner lookup
meator Aug 21, 2026
87407c9
Make qmlimportscanner more robust
meator Aug 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 20 additions & 12 deletions src/qml.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,26 +26,34 @@ using namespace nlohmann;
namespace fs = std::filesystem;

fs::path findQmlImportScanner() {
auto path = which("qmlimportscanner");
if (path.empty()) {
// at least on FreeBSD the qmlimportscanner binary is installed under
// QT_INSTALL_LIBEXECS for Qt 6 and QT_INSTALL_BINS for Qt5,
// so is not locatable via $PATH
auto qmakeVars = queryQmake(findQmake());
path = which(qmakeVars["QT_INSTALL_LIBEXECS"] + "/qmlimportscanner");
if (path.empty())
path = which(qmakeVars["QT_INSTALL_BINS"] + "/qmlimportscanner");
}
// Calling plain which("qmlimportscanner") is problematic, because it
// is symlinked to qtchooser on some distros. qtchooser's Qt6 support
// is less than ideal, qmlimportscanner used to be in
// /usr/lib/qt5/bin/qmlimportscanner, but it was moved to
// /usr/lib/qt6/libexec/qmlimportscanner in Qt6. qtchooser is capable
// of checking only a single directory for executables at a time,
// and it usually checks the bin/ one, so qmlimportscanner cannot
// be executed on Qt6 (if you are flabbergasted by this, remember that
// current latest release of qtchooser, 66_3, doesn't even include a
// qt6 config lookup file).
// Either way, QT_INSTALL_LIBEXECS/QT_INSTALL_BINS lookup is the more
// robust solution.
auto qmakeVars = queryQmake(findQmake());
auto path = which(qmakeVars["QT_INSTALL_LIBEXECS"] + "/qmlimportscanner");
if (path.empty())
path = which(qmakeVars["QT_INSTALL_BINS"] + "/qmlimportscanner");
if (path.empty())
path = which("qmlimportscanner");

return path;
}

std::string runQmlImportScanner(const std::vector<std::filesystem::path> &sourcesPaths, const std::vector<fs::path> &qmlImportPaths) {
auto qmlImportScannerPath = findQmlImportScanner();

if (findQmlImportScanner().empty()) {
if (qmlImportScannerPath.empty()) {
// TODO: come up with some more user friendly logging like it's done for qmake
throw std::runtime_error("error: qmlimportscanner not found $PATH");
throw std::runtime_error("error: qmlimportscanner not found in Qt standard directories nor PATH");
}

std::vector<std::string> command{qmlImportScannerPath.string()};
Expand Down
Loading