nemo-file-conflict-dialog.c: Load folder sizes before display. - #3828
Open
BreezeDelegate wants to merge 1 commit into
Open
nemo-file-conflict-dialog.c: Load folder sizes before display.#3828BreezeDelegate wants to merge 1 commit into
BreezeDelegate wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The conflict dialog waits for icon metadata before reading
size, but directory sizes depend on the directory item count. If the target folder has not been expanded yet, that count is unavailable and the dialog displays(null).Wait for item counts on the two conflicting files before building the dialog, and use Nemo's non-null fallback for counts that are intentionally unavailable. The parent directory is no longer part of the wait list, so it is not counted unnecessarily.
Tested with a full Debian package build in the official Linux Mint 22.3 image and a targeted async metadata check reproducing
(null)before the count and0 itemsafter it.Fixes #3442