Skip to content

Combined unit/integration test code coverage in CI - #289

Merged
alan-george-lk merged 2 commits into
mainfrom
alan/feature-combined-coverage
Oct 16, 2026
Merged

alan-george-lk merged 2 commits into
mainfrom
alan/feature-combined-coverage

Conversation

@alan-george-lk

@alan-george-lk alan-george-lk commented Oct 15, 2026 •

Copy link
Copy Markdown
Collaborator

Our prior code coverage numbers only included unit tests. This branch updates that to also include integration tests, which are also GTest-based. Just needed to wire up the coverage results better.

@alan-george-lk
alan-george-lk marked this pull request as ready for review October 15, 2026 14:30
@alan-george-lk
alan-george-lk requested review from a team and xianshijing-lk as code owners October 15, 2026 14:30
devin-ai-integration[bot]

This comment was marked as resolved.

@stephen-derosa stephen-derosa left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how does GTest know what % of integration is covered? For unit its a bit easier to understand "do all lines of code get hit" (give or take), but how does it work for integration?

Also looks like Devin left some reasonable comments

run: |
set -euo pipefail
source scripts/set-test-tokens.sh
# TODO(BOT-477) Temporarily disable platform audio integration tests in CI until instability is resolved

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be

# TODO(BOT-477) enable platform audio integration tests in CI when stable

?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment is old, just showing up because of the changes, it meant disable platform audio tests via the GTest arg below until it works, which there is a fix in rust-sdks for (waiting on user-contributor to resolve devin flags)

@alan-george-lk

Copy link
Copy Markdown
Collaborator Author

how does GTest know what % of integration is covered? For unit its a bit easier to understand "do all lines of code get hit" (give or take), but how does it work for integration?

Also looks like Devin left some reasonable comments

@stephen-derosa It works the same both ways, integration test coverage is also lines of code/functions hit

Co-authored-by: Cursor <cursoragent@cursor.com>
@alan-george-lk
alan-george-lk merged commit 80130a2 into main Oct 16, 2026
20 checks passed
@alan-george-lk
alan-george-lk deleted the alan/feature-combined-coverage branch October 16, 2026 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants