Skip to content

fix(simulate): offer lk cloud auth when no project is linked #1045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
u9g wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(simulate): offer lk cloud auth when no project is linked #1045

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3d4e55b
fix(simulate): offer `lk cloud auth` when no project is linked
u9g Oct 15, 2026
63d5728
fix(simulate): drop unused ctx from requireProject
u9g Oct 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions cmd/lk/simulate.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,21 +116,20 @@ var simulateCommand = &cli.Command{
// `list` and `cancel` never hit the API-key project gate.
//
// TODO(DEVX-577): unify text/audio/view/export with --experimental-auth. For
// now they stay API-key only (loadProjectDetails rejects --experimental-auth).
// now they stay API-key only (requireProject rejects --experimental-auth).
// Blockers: a spawned agent needs API keys to register as a worker, and the
// Public API can't issue them; it also lacks a confirm-source-upload op, and
// its create has no audio-impairment or CI fields. Live-agent mode
// (--agent-name + --scenarios) could work over the Public API today, but its
// oapi run type would need converting to the livekit.SimulationRun the TUI,
// CI report and export consume.
func loadSimulateProject(ctx context.Context, cmd *cli.Command) (context.Context, error) {
pc, err := loadProjectDetails(cmd)
if err != nil {
if _, err := requireProject(ctx, cmd); err != nil {
return nil, err
}
simulateProjectConfig = pc
simulateProjectConfig = project
if !cmd.IsSet("server-url") {
if api := cloudAPIURL(pc.URL); api != "" {
if api := cloudAPIURL(project.URL); api != "" {
serverURL = api
}
}
Expand Down
Loading