Repository navigation
Conversation
Earlier releases pass the 1.0.0 floor but reject --simulation, so the agent exits before registering with "unknown option '--simulation'".
The fatal markers only matched Python log lines, so a Node agent whose entrypoint threw surfaced only as "No agent joined room" timeouts.
Contributor
Author
|
Before/after on a Node agent. With @livekit/agents 1.4.9, main dies on node-sim.mp4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two ways
lk agent simulatedead-ends Node agent users, with no hint at the cause.1. @livekit/agents 1.0.0–1.4.9 pass the version check, then die. The CLI's Node floor is 1.0.0. Simulate, though, starts the agent with
--simulationandLIVEKIT_AGENT_NAME_OVERRIDE, and both first shipped in 1.4.11 (1.4.10 was never published). On 1.4.9 the user getsthe agent exited before registering. Agent output: error: unknown option '--simulation'. Projects created from agent-starter-node before 2026-06-30 pin^1.4.7, often held there by a lockfile. Simulate now checks for 1.4.11 and says@livekit/agents version 1.4.9 is too old, please upgrade to 1.4.11 or newer. The shared 1.0.0 floor fordev/start/consoleis unchanged, since those commands don't use either flag.2. A Node agent that crashes in
entry()shows only "No agent joined room". Broken-agent detection matched only Python log lines. A throwing Node entrypoint left every job to time out at 30s, and the real error stayed in the temp agent log. The 3-scenario starter can never reach the more-than-3 "not joined" threshold, so the run always played out in full. Adding agents-js'serror in entry function(job_lifecycle.ts) to the markers lets the existing path cancel the run and print the error.Repro (starter Node agent,
CI=1 lk agent simulate text --scenarios scenarios.yaml --yes):@livekit/agents1.4.9: main printsunknown option '--simulation'. This branch prints the upgrade message.throw new Error("boom: missing API key")at the top ofentry(): main took 73–92s, with 3 of 3 jobs failing onNo agent joined room. This branch cancelled within 9–18s and printederror in entry function: boom: missing API key.The broken-agent path still exits 0 in CI on main. That's fixed separately in #1047.
Commits: a pure refactor that makes the version check take the floor as a parameter, then one commit per fix.
go test ./cmd/lk/passes.