Repository navigation
fix(rtc-node): size NV12 and I420A chroma planes from the chroma height - #767
Open
ninglinLiu wants to merge 1 commit into
Open
ninglinLiu wants to merge 1 commit into
ninglinLiu wants to merge 1 commit into
Conversation
getPlaneLength multiplied chromaWidth by itself for NV12 and I420A, so VideoFrame.fromOwnedInfo copied too many bytes for landscape frames (reading past the native buffer) and too few for portrait frames. Fixes livekit#746
🦋 Changeset detectedLatest commit: 4054b1b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #746
getPlaneLengthcomputed the chroma planes of NV12 and I420A frames aschromaWidth * chromaWidth * 2.VideoFrame.fromOwnedInfouses that length to copy frames out of native memory (video stream frames andVideoFrame.convert()results), so for non-square frames it read past the end of the native buffer (landscape, e.g. 1280x720 NV12: 1,740,800 bytes instead of 1,382,400) or truncated the frame (portrait).This uses
chromaHeight, matchinggetPlaneInfosand the I420 case.Changes
getPlaneLength: usechromaWidth * chromaHeightfor NV12 and I420A, and export it as@internalso it can be unit tested (not re-exported fromindex.ts).video_frame.test.ts: checks I420/I420A/NV12 lengths for landscape, portrait and odd-sized frames, plus 1280x720 NV12.@livekit/rtc-node.Testing
pnpm --filter @livekit/rtc-node test: the new tests pass; the NV12/I420A cases fail without the fix. (The e2e test files need a builtlivekit-server-sdkand are unchanged.)