Skip to content

feat: forward orchestrators list through reserve_session#37

Open
rickstaa wants to merge 1 commit into
ja/live-runnerfrom
feat/reserve-session-orchestrators-list
Open

feat: forward orchestrators list through reserve_session#37
rickstaa wants to merge 1 commit into
ja/live-runnerfrom
feat/reserve-session-orchestrators-list

Conversation

@rickstaa

@rickstaa rickstaa commented Jul 7, 2026

Copy link
Copy Markdown
Member

Forwards the existing orchestrators param (already supported by runner_selector / discover_orchestrator_runners / orchestrator_discovery_urls) through the reserve_session() convenience wrapper, so callers can select across a list or comma-delimited string of orchestrator URLs directly:

reserve_session(orchestrators="http://orch1:48936,http://orch2:8935", app=APP_ID, signer_url=signer)

Useful for testing/selecting across a chosen set of orchs without standing up a remote signer + /discover-orchestrators aggregator. Direct per-orch discovery, so it works with any app id. Two-line passthrough, no behavior change when the param is omitted.

Closes #36

@coderabbitai

coderabbitai Bot commented Jul 7, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: dd71e3ca-3cb0-4b07-b32d-3a2276ac70f9

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/reserve-session-orchestrators-list

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@rickstaa rickstaa marked this pull request as draft July 7, 2026 19:13
@rickstaa rickstaa force-pushed the feat/reserve-session-orchestrators-list branch from 40fd766 to 47f311b Compare July 10, 2026 20:37
@rickstaa rickstaa requested a review from j0sh July 10, 2026 20:38
@rickstaa rickstaa force-pushed the feat/reserve-session-orchestrators-list branch from 47f311b to 6a68b59 Compare July 10, 2026 20:38
Let reserve_session() select across a list (or comma-delimited string) of
orchestrator URLs directly, without standing up a remote signer aggregator.
runner_selector/discover_orchestrator_runners already accept orchestrators;
this just forwards the param through the convenience wrapper.
@rickstaa rickstaa force-pushed the feat/reserve-session-orchestrators-list branch from 6a68b59 to 121b0ad Compare July 10, 2026 20:39
@rickstaa rickstaa marked this pull request as ready for review July 10, 2026 20:55

@eliteprox eliteprox left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fix works, it is important for live-runner selection

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants