feat: forward orchestrators list through reserve_session#37
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
40fd766 to
47f311b
Compare
47f311b to
6a68b59
Compare
Let reserve_session() select across a list (or comma-delimited string) of orchestrator URLs directly, without standing up a remote signer aggregator. runner_selector/discover_orchestrator_runners already accept orchestrators; this just forwards the param through the convenience wrapper.
6a68b59 to
121b0ad
Compare
eliteprox
left a comment
There was a problem hiding this comment.
This fix works, it is important for live-runner selection
Forwards the existing
orchestratorsparam (already supported byrunner_selector/discover_orchestrator_runners/orchestrator_discovery_urls) through thereserve_session()convenience wrapper, so callers can select across a list or comma-delimited string of orchestrator URLs directly:Useful for testing/selecting across a chosen set of orchs without standing up a remote signer +
/discover-orchestratorsaggregator. Direct per-orch discovery, so it works with any app id. Two-line passthrough, no behavior change when the param is omitted.Closes #36