Isolate AMS from PyTorch - #196
Open
lpottier wants to merge 9 commits into
Open
Conversation
…CH=On except integration tests) Signed-off-by: Loic Pottier <pottier1@llnl.gov>
Signed-off-by: Loic Pottier <pottier1@llnl.gov>
Signed-off-by: Loic Pottier <pottier1@llnl.gov>
Signed-off-by: Loic Pottier <pottier1@llnl.gov>
Signed-off-by: Loic Pottier <pottier1@llnl.gov>
Signed-off-by: Loic Pottier <pottier1@llnl.gov>
Signed-off-by: Loic Pottier <pottier1@llnl.gov>
Signed-off-by: Loic Pottier <pottier1@llnl.gov>
lpottier
force-pushed
the
features/remove-torch
branch
from
August 21, 2026 21:41
94df04e to
1820329
Compare
Signed-off-by: Loic Pottier <pottier1@llnl.gov>
Contributor
Cpp-Linter Report
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims at removing PyTorch from the critical path in AMS. The strict dependency on PyTorch prevents AMS from being used in some multi-physics codes and thus must be removed. This PR introduces the CMake flag
-DWITH_TORCH=[On|Off].This PR replaces Torch tensors with
AMSTensorwhen possible. By default,-DWITH_TORCH=On, when AMS is compiled with Torch we can perform inference but when we do not compile AMS with Torch we can still store physics and it acts as atraining onlymode.TODO:
evaluate()