Repository navigation
chore: update pull request template #2645
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,27 @@ | ||
| #### Description | ||
| <!-- Description here --> | ||
|
|
||
| #### Changes | ||
| <!-- Changes here --> | ||
|
|
||
| #### Checklist | ||
|
|
||
| - [ ] Update version code if an existing plugin was modified | ||
| - [ ] Test changes in Plugin Playground or the app | ||
| - [ ] Reference related issues in the PR body (e.g. Closes #xyz) | ||
| - [ ] Commit messages follow `type(scope): description` (e.g. `feat(<generator>): add new source`) | ||
|
|
||
| #### Check results | ||
| Link repo: | ||
| ``` | ||
| <!-- Link repo URL here --> | ||
| ``` | ||
| Link novel: | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The template asks every contributor for a novel link and before-and-after images. A new plugin has no earlier state, and the self-hosted |
||
| ``` | ||
| <!-- Link novel URL here --> | ||
| ``` | ||
| Before: | ||
| <!-- Image before here --> | ||
|
|
||
| After: | ||
| <!-- Image after here --> | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new URL placeholders are inside code blocks, so they appear as text in the PR body instead of disappearing. URLs entered there also won't be clickable. Put the prompts outside the code blocks and let contributors enter ordinary Markdown links.
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!