Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,27 @@
#### Description
<!-- Description here -->

#### Changes
<!-- Changes here -->

#### Checklist

- [ ] Update version code if an existing plugin was modified
- [ ] Test changes in Plugin Playground or the app
- [ ] Reference related issues in the PR body (e.g. Closes #xyz)
- [ ] Commit messages follow `type(scope): description` (e.g. `feat(<generator>): add new source`)

#### Check results
Link repo:
```
<!-- Link repo URL here -->
Comment on lines +16 to +17

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 PR links render as code

The new URL placeholders are inside code blocks, so they appear as text in the PR body instead of disappearing. URLs entered there also won't be clickable. Put the prompts outside the code blocks and let contributors enter ordinary Markdown links.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

```
Link novel:

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Some prompts cannot be filled

The template asks every contributor for a novel link and before-and-after images. A new plugin has no earlier state, and the self-hosted KomgaPlugin has no public novel URL. Mark these prompts as optional or say when to skip them, so contributors don't have to leave unexplained blanks or provide unrelated examples.

```
<!-- Link novel URL here -->
```
Before:
<!-- Image before here -->

After:
<!-- Image after here -->
Loading