Conversation
Config-only PR for Q4 Quality Platform pilot. Secrets and workflows added after. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
wjia89
changed the title
wjia89
force-pushed
the
plat-vendor-integration-lob-java
branch
from
September 28, 2026 15:03
0a05295 to
b1e6403
Compare
Workflows reference secrets that will be added separately. Guardrails false positive on secret syntax will be flagged off. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Codecov upload should be added to existing test workflows, not run as separate job with no coverage files. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
|
Closing: lob-java is public SDK, not suitable for internal quality tool pilot. |
|
Closing: lob-java is public SDK, replaced with presort-api (PLAT-3701) |
|
Closing: lob-java is public SDK, unsuitable for internal quality tool integration. Replaced with presort-api (PLAT-3701). |
1 similar comment
Author
|
Closing: lob-java is public SDK, unsuitable for internal quality tool integration. Replaced with presort-api (PLAT-3701). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
sonar-project.properties- SonarQube config with language-specific pathscodecov.yml- Non-blocking coverage reporting (informational: true).trunk/trunk.yaml- Linting config (language-specific linters + trufflehog)Test plan
SONAR_TOKEN,SONAR_HOST_URL,CODECOV_TOKENsecrets.github/workflows/sonarqube.yml,.github/workflows/codecov.yml)Security review
✅ SHA-pinned actions (when workflows added)
✅ Least privilege permissions (
contents: read)✅ Non-blocking integration (
informational: true,continue-on-error: true)✅ No secrets in config files
Rollback
Auto: Revert this PR's merge commit:
git revert <commit-sha>Manual: Delete 3 config files:
Why config-only?
Guardrails blocks workflows referencing non-existent secrets. Proper sequencing: generate secrets → add workflows → test integration.
🤖 Generated with Claude Code