ci: enforce formula style and audit - #11
Merged
Merged
Conversation
localstack/localstack-cli#57 fixed the generator, and v2026.8.2 regenerated Formula/localstack-cli.rb from it: style and audit --online are both clean on main, so the formula step no longer needs continue-on-error. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
joe4dev
marked this pull request as ready for review
September 28, 2026 12:36
anisaoshafi
approved these changes
Sep 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
#10 ran the
localstack-cliformula checks withcontinue-on-error: true, because the generated formula had 5 style offences and 7 audit problems. That escape hatch was scheduled to close once localstack/localstack-cli#57 landed and a release regenerated the formula.Both have happened: #57 merged, and v2026.8.2 (5e10c62) regenerated
Formula/localstack-cli.rbfrom the fixed generator.Change
Drop
continue-on-error: trueand its TODO from the formula step. A formula style or audit failure now fails the job.if: always()and the|| rc=1pattern stay, so the formula is still checked when a cask step fails, and a style failure still lets the audit run.Validation
mainafter 5e10c62 (run): formula style reports no offenses, audit--onlinereports no problems.workflow_dispatch(run): every step green, with the formula step enforced.Remaining
The
--except-cops=Cask/StanzaOrderexception from #10 is still waiting on localstack/lstk#512 and is unchanged here.🤖 Generated with Claude Code