Skip to content

Accept empty authoritative sync transactions and expose safe failure details - #101

Merged
RCmerci merged 3 commits into
mainfrom
codex/authoritative-empty-pr-20261020
Oct 20, 2026
Merged

RCmerci merged 3 commits into
mainfrom
codex/authoritative-empty-pr-20261020

Conversation

@RCmerci

@RCmerci RCmerci commented Oct 20, 2026

Copy link
Copy Markdown
Contributor

Authoritative sync batches containing an empty Transit array/list currently fail before application. Accept those transactions only at the three authoritative-input boundaries, retaining their batch slots, cursor/token advancement and existing atomic commit/rollback checks. Outgoing-record validation remains strict.

The existing Diagnostics surface now preserves finite authoritative failure categories and bounded decode stage/reason details instead of one generic transition rejection. Raw transaction text, identifiers, credentials and arbitrary exception messages are excluded.

Validation on final head 782bed96e29aafc1a1ade56bb66e2caaea020c93:

  • dune build -j1 --display=quiet @all and complete forced dune runtest: 21 Alcotest suites / 1005 cases, plus standalone boundary checks.
  • Independent read-only review passed, with no evidenced P1/P2 findings.
  • Public Database regressions cover empty arrays/lists, mixed batch slots, checkpoint/token persistence after reopen, stale tokens, late decode failure, actual SQLite commit rollback, and strict outgoing-empty rejection.

Build52 at this exact source and later Build57 were installed and launched on iPhone. This does not establish successful re-download of the original failed attachment or complete runtime/ABI acceptance; the existing device build route is experimental (cross_abi_validated=false). Closed/token producer races and mounted Diagnostics UI are not fully covered by these tests.

This PR contains only the three selected authoritative-sync commits based on a0746e9. The separate attachment-diagnostic work and startup sampling are excluded. No Dune or protected spec/ changes.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-20T11:50:44.756047Z 782bed9 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@RCmerci
RCmerci merged commit 01e6bfe into main Oct 20, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant