Repository navigation
Accept empty authoritative sync transactions and expose safe failure details - #101
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Authoritative sync batches containing an empty Transit array/list currently fail before application. Accept those transactions only at the three authoritative-input boundaries, retaining their batch slots, cursor/token advancement and existing atomic commit/rollback checks. Outgoing-record validation remains strict.
The existing Diagnostics surface now preserves finite authoritative failure categories and bounded decode stage/reason details instead of one generic transition rejection. Raw transaction text, identifiers, credentials and arbitrary exception messages are excluded.
Validation on final head
782bed96e29aafc1a1ade56bb66e2caaea020c93:dune build -j1 --display=quiet @alland complete forceddune runtest: 21 Alcotest suites / 1005 cases, plus standalone boundary checks.Build52 at this exact source and later Build57 were installed and launched on iPhone. This does not establish successful re-download of the original failed attachment or complete runtime/ABI acceptance; the existing device build route is experimental (
cross_abi_validated=false). Closed/token producer races and mounted Diagnostics UI are not fully covered by these tests.This PR contains only the three selected authoritative-sync commits based on
a0746e9. The separate attachment-diagnostic work and startup sampling are excluded. No Dune or protectedspec/changes.