Repository navigation
Read non-Transit attachments in encrypted graphs - #102
Merged
Merged
Conversation
Port the compatibility behavior directly onto main without the unselected asset-diagnostic infrastructure. Clear non-Transit bytes use existing plaintext limits/checksum and unchanged safe publication; Transit candidates and crypto failures never fall back. Keep path evidence fixed and payload-free. Add public codec regressions for success, malformed/truncated candidates, authentication, limits, checksum and exception boundaries.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Encrypted graphs currently reject clear non-Transit attachment bytes at the AES-GCM envelope gate. Classify those bytes before bounded envelope parsing, then reuse the existing plaintext length/SHA-256 validation and unchanged safe cache publication.
JSON/Transit-looking candidates, including malformed/truncated envelopes, still use the existing rejection path. Invalid IV/ciphertext, parser errors, wrong keys, authentication errors, crypto exceptions and decrypted-checksum failures never fall back, even when the raw response checksum matches. JSON-looking raw files remain conservatively rejected. The new log is fixed path-selection text with no content, identifiers, hashes or credentials.
This is a minimal standalone port directly onto main: one commit, three files, no dependency on the separate attachment-diagnostic work. It does not add the diagnostic carrier, shape/format/header observers or typed failure channel, and does not change graph flags, upload, transport, retry, cache policy, spec interfaces, Dune or dependencies.
Validation on final head
c9339d45f0efc7c96f39627754a8071afaa98931:dune build -j1 --display=quiet @alland complete forceddune runtest: 21 Alcotest suites / 976 cases, plus standalone boundary checks.Device evidence applies to earlier Build57 (
0d05d1a951f5ccf3ea2c1053401e9629c67be712), which installed and launched with the same compatibility behavior plus additional diagnostic work. It is not device validation of this standalone PR head. Successful re-download of the original failed attachment remains unconfirmed. No iPhone operation or Apple app rebuild was performed for this split; the earlier device route remains experimental (cross_abi_validated=false).