Repository navigation
Streamline explicit bootstrap actions and center graph recovery buttons - #104
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Selecting a graph marked “Not downloaded” previously stopped on an expected missing-mirror error and required another “Download graph” click. The picker now says “Download and open”; an explicit selection with a confirmed absent mirror requests scoped native online permission directly. Automatic recent-graph restore stays local, and authentication, key recovery, cancellation and bounded failures remain in place.
“Sign in again” now starts native authentication once per explicit retry presentation, removing the repeated Continue step while preserving the initial explanation, cancellation, account preparation and visible failure/retry feedback. Both interactions were measured at 2 → 1 clicks in the isolated synthetic UI test.
Also center the existing “Unable to open graph” recovery action group with a native row, preserving its button order and handlers. Single/multiple actions, an actual 320-point host width and accessibility-medium sizing were checked; visible labels can still ellipsize at that large size, which is outside this alignment correction. Duplicate Retry controls and title overlap are excluded.
Validation:
Limits: actual production-server sign-in/download success, password unlock and successful network restoration/download interruption recovery were not verified. UI observations used a synthetic account, in-memory fixture keys and an adapter that deliberately fails token requests. The explicitly authorized experimental host-restamp build retains
cross_abi_validated=false; this is not Simulator/device ABI certification. LUI remains pinned to4fdb9136026af7863a8d025133871e34864eace1.The decision document for this change validates. Repository-wide decision-document validation still reports five pre-existing historical formatting errors; unrelated documents are unchanged.