Skip to content

Streamline explicit bootstrap actions and center graph recovery buttons - #104

Merged
RCmerci merged 5 commits into
mainfrom
codex/bootstrap-direct-actions-20261021
Oct 21, 2026
Merged

RCmerci merged 5 commits into
mainfrom
codex/bootstrap-direct-actions-20261021

Conversation

@RCmerci

@RCmerci RCmerci commented Oct 21, 2026

Copy link
Copy Markdown
Contributor

Selecting a graph marked “Not downloaded” previously stopped on an expected missing-mirror error and required another “Download graph” click. The picker now says “Download and open”; an explicit selection with a confirmed absent mirror requests scoped native online permission directly. Automatic recent-graph restore stays local, and authentication, key recovery, cancellation and bounded failures remain in place.

“Sign in again” now starts native authentication once per explicit retry presentation, removing the repeated Continue step while preserving the initial explanation, cancellation, account preparation and visible failure/retry feedback. Both interactions were measured at 2 → 1 clicks in the isolated synthetic UI test.

Also center the existing “Unable to open graph” recovery action group with a native row, preserving its button order and handlers. Single/multiple actions, an actual 320-point host width and accessibility-medium sizing were checked; visible labels can still ellipsize at that large size, which is outside this alignment correction. Duplicate Retry controls and title overlap are excluded.

Validation:

  • Full final-head build and regression run: 21 Alcotest suites / 1012 cases, plus standalone checks.
  • Four public pure-core regressions in the existing test file; existing picker label expectations updated, with no duplicate UI regression cases.
  • Swift authentication model checks and actual UI cancellation/retry, local-graph restore/restart/background, picker cancellation and missing-key protection.
  • Independent read-only review of the final head: no definite findings.
  • Eight-page synthetic before/after screenshot report delivered to the requester through ChatGPT Library; it is requester-accessible evidence, not a public GitHub attachment. No private local paths or user graph data are published here.

Limits: actual production-server sign-in/download success, password unlock and successful network restoration/download interruption recovery were not verified. UI observations used a synthetic account, in-memory fixture keys and an adapter that deliberately fails token requests. The explicitly authorized experimental host-restamp build retains cross_abi_validated=false; this is not Simulator/device ABI certification. LUI remains pinned to 4fdb9136026af7863a8d025133871e34864eace1.

The decision document for this change validates. Repository-wide decision-document validation still reports five pre-existing historical formatting errors; unrelated documents are unchanged.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-21T06:33:59.007323Z b42538f PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@RCmerci
RCmerci merged commit 9288007 into main Oct 21, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant