Repository navigation
Restore original Logseq Journal app display name - #106
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restore
CFBundleDisplayNameto the exact originalLogseq Journalvalue from PR104/main9288007aaab2b34d54177d36352457968862e591, reverting only the display-name change from #105.Build
1.0 (1.5877.60)was transmitted successfully, then failed Apple processing with90129: The bundle uses a bundle name or display name that is already taken.This PR restores the owner's prior name; it does not change the App Store Connect store name or assume that was the affected field.Bundle ID
com.logseq.journal, internalCFBundleName, callback scheme, executable/product references, App Store Connect app identity, testing groups and members remain unchanged. PR104 and all other merged functionality are retained.Validation: temporary source-plist comparison confirmed the original value exactly and every other key unchanged;
git diff --checkpassed. No test files, products, signing material or private evidence are included. Independent review found no defects and confirmed the parsed plist exactly matches the original revision. Exact-head CI is pending. A new signed package will be verified against its actual source revision before any resubmission; build60 is not silently retried. Host-restamp remains experimental withcross_abi_validated=false.