Repository navigation
fix(sync): initialize downloads from snapshot metadata - #107
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 59c12a9672
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial graph downloads now request
GET /sync/{graph-id}/snapshot/downloaddirectly and initialize the mirror from its validated non-negative integert. This removes the preliminaryGET /sync/{graph-id}/pullrequest (which omittedsince; the server defaulted it to 0). Snapshot completions are fenced to their requested graph so a late result after graph selection cannot activate another graph's URL, cursor, or artifact.This follows logseq/logseq#13814 and upstream 69da7e2215. Metadata precedes a live stream, so its cursor is preserved for subsequent catchup rather than advanced to a presumed snapshot boundary. Missing/invalid
tfails visibly before downloading, matching current upstream; there is no legacy HTTP pull fallback. Existing metadata fields, incremental WebSocket pulls, and optional canonical acknowledgement compatibility remain supported.Validation on head
9105e97:tshows an error without a stream request; Retry obtainst=0, imports 412 framed rows, activates, then catches up via WSsince=0andsince=1; durable SQLite cursor reaches 2. UI shows Current / Ready / Open without Last error; Ping/Pong is recorded. No initialization HTTP/pulloccurs.9105e97and their regression/fixture checks passed.Simulator evidence uses fixture authentication and fixture-only localhost certificate trust. It exercises real UI, TLS transport, stream import, activation, and SQLite catchup; real-account login, production TLS, and E2EE were not verified. Host-restamp remains experimental with
cross_abi_validated=false. Test adapters, screenshots, logs, and generated apps remain outside the PR. No merge, deployment, or release changes.