Repository navigation
fix: finish encrypted mirror unlock before Timeline presentation - #108
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After sign-out retains an encrypted local mirror but clears its unlock credentials, signing in and entering a valid E2EE password can leave the App on “Unlocking”. The graph has attached successfully, but Application waits for startup Ready to finish the submission. Ready waits for Timeline's first-appearance acknowledgement, while the pending password screen prevents Timeline from mounting.
Finish the submission when the same account/graph generations and selected graph report an attached mirror: local access is available, restoration has ended, and first presentation is pending. Local availability alone and command admission do not count as success. Keep the scoped Timeline appearance acknowledgement and existing password-error, failure, and scope-replacement handling.
Validation on head
22b87bca2aa83fd6b2c67ec10b1b53b4a7394e10:cross_abi_validated=false; this is not iPhoneOS ABI acceptance.Scope is the existing-mirror unlock presentation cycle, its regressions, and the repository decision record.