Skip to content

fix: finish encrypted mirror unlock before Timeline presentation - #108

Merged
RCmerci merged 1 commit into
mainfrom
fix/existing-mirror-unlock-completion
Oct 21, 2026
Merged

RCmerci merged 1 commit into
mainfrom
fix/existing-mirror-unlock-completion

Conversation

@RCmerci

@RCmerci RCmerci commented Oct 21, 2026

Copy link
Copy Markdown
Contributor

After sign-out retains an encrypted local mirror but clears its unlock credentials, signing in and entering a valid E2EE password can leave the App on “Unlocking”. The graph has attached successfully, but Application waits for startup Ready to finish the submission. Ready waits for Timeline's first-appearance acknowledgement, while the pending password screen prevents Timeline from mounting.

Finish the submission when the same account/graph generations and selected graph report an attached mirror: local access is available, restoration has ended, and first presentation is pending. Local availability alone and command admission do not count as success. Keep the scoped Timeline appearance acknowledgement and existing password-error, failure, and scope-replacement handling.

Validation on head 22b87bca2aa83fd6b2c67ec10b1b53b4a7394e10:

  • Two new regressions execute Application's existing public mounted hooks, covering manager-first and graph-first notifications. Both fail before the production fix and pass afterward; they also verify that local availability alone stays pending and that native appearance still sends the current scoped acknowledgement.
  • Full Application suite: 144 passed. Full sync suite: 303 passed, including existing late E2EE completion/scope fencing and protocol tests. Startup tests passed.
  • Independent read-only source review: no findings.
  • The exact fix was installed as an update to the isolated Journal Real Unlock App on an iPhone 13 Simulator (iOS 26.1), preserving its local graph data. The user entered their own credentials and confirmed the real-service sign-out → sign-in → encrypted graph → E2EE password path now succeeds. Independent read-only checks confirmed the selected encrypted mirror remains active with no recorded sync error. UI success is user-reported; no password or private graph content was captured.
  • Simulator uses the previously selected experimental host-restamp route with cross_abi_validated=false; this is not iPhoneOS ABI acceptance.

Scope is the existing-mirror unlock presentation cycle, its regressions, and the repository decision record.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-21T11:09:04.997244Z 22b87bc PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@RCmerci
RCmerci merged commit 9198bd2 into main Oct 21, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant