Repository navigation
Restore local account before publishing the root UI - #109
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Startup published the LUI root immediately after native admission, allowing SwiftUI initialization to delay local account restoration. Buffer admission-time callbacks, deliver them after native start/connect, and publish the root after the initial platform tasks finish. Generation checks fence cancellation and stale responses; the host retains the starting runtime until cleanup completes.
Validation on
6684ce28e094753d1579511fc230d47581f75862:dune build @all app/native_embed.exe.o,dune runtest --force, and Swift platform/account recovery tests passed. Independent exact-head review found no blocking new defect.Limits: Simulator iPhone 13/iOS 26.1, Swift Debug/OCaml dev, experimental-host-restamp,
cross_abi_validated=false. These are lifecycle proxies, not GPU presentation or device Release results; the paired iPhone is unavailable.Known baseline boundary: immediate synchronous stop/start can reject the second native admission (reproduced with original main Runtime, 1/3 attempts). Asynchronous worker disposal is a supported explanation but its internal state was not captured. The final candidate stop comparison passed 3/3, while two earlier unlocalized stop failures remain recorded. This PR does not claim to fix that existing native restart race. Five pre-existing agent-document format errors also remain unchanged.