Conversation
Signed-off-by: duanjialing.777 <duanjialing.777@bytedance.com>
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SqliteAuthorityStoreRoot cause
authority_archive.test.tswas added after the minimum-runtime lane established its SQLite exclusions. The file mixes File and SQLite rows, so Node 22.18 executes SQLite authority code even though that runtime intentionally lacks the admitted WAL-reset SQLite release. The archive implementation PR already showed this failure innode-minimum-compatibility(job); the same nine failures reproduced on PRs #4905 and #4906.This change uses the same
sqliteAuthorityRuntime()skip pattern as the existing mixed-provider tests. It skips only rows that require SQLite.Validation
Before the change:
authority_archive.test.tsAfter the change:
npm run typecheck:control-planegit diff --checkNo runtime or persisted-state behavior changes.