Skip to content

test(authority): gate SQLite archive rows by runtime - #4908

Closed
Duang777 wants to merge 1 commit into
loopx-project:mainfrom
Duang777:codex/fix-authority-archive-node-minimum
Closed

Duang777 wants to merge 1 commit into
loopx-project:mainfrom
Duang777:codex/fix-authority-archive-node-minimum

Conversation

@Duang777

Copy link
Copy Markdown
Contributor

Summary

  • apply the existing SQLite runtime-admission skip to archive tests that construct SqliteAuthorityStore
  • keep File archive export, restore, corruption, and interrupted-recovery coverage running on the public minimum Node version
  • keep all 22 archive cases active on the qualified runtime

Root cause

authority_archive.test.ts was added after the minimum-runtime lane established its SQLite exclusions. The file mixes File and SQLite rows, so Node 22.18 executes SQLite authority code even though that runtime intentionally lacks the admitted WAL-reset SQLite release. The archive implementation PR already showed this failure in node-minimum-compatibility (job); the same nine failures reproduced on PRs #4905 and #4906.

This change uses the same sqliteAuthorityRuntime() skip pattern as the existing mixed-provider tests. It skips only rows that require SQLite.

Validation

Before the change:

  • Node 22.18: 13 passed, 9 failed in authority_archive.test.ts
  • Node 24.16: 22 passed

After the change:

  • Node 22.18: 14 passed, 8 skipped, 0 failed
  • Node 24.16: 22 passed, 0 skipped
  • npm run typecheck:control-plane
  • git diff --check

No runtime or persisted-state behavior changes.

Signed-off-by: duanjialing.777 <duanjialing.777@bytedance.com>
@Duang777

Copy link
Copy Markdown
Contributor Author

Superseded by #4906. The Node-minimum archive fix is now commit 499c7ef on that PR so the timeout and runtime-admission fixes can produce one self-consistent CI run. No code from this PR was dropped.

@Duang777 Duang777 closed this Sep 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant