Skip to content

Exercise research record search in the Dashboard source coverage lane - #8726

Closed
loopx-agent wants to merge 2 commits into
codex/audit-dashboard-startup-pr-20261114from
codex/audit-dashboard-research-source-pr-20261114
Closed

loopx-agent wants to merge 2 commits into
codex/audit-dashboard-startup-pr-20261114from
codex/audit-dashboard-research-source-pr-20261114

Conversation

@loopx-agent

Copy link
Copy Markdown
Collaborator

Research record search now starts on the Vite source page in the Dashboard source coverage lane. It still queries the real isolated paged history owner in both lanes. Previously, the source runner opened the packaged page for this scenario and could report a pass without instrumenting the source component.

The source test now requires coverage for the research record search component and both lanes check that the history owner was read without mutation. The existing focus recovery regression remains in the scenario.

Development with source coverage and packaged Chat both passed. Seven quick premerge checks passed, including the bilingual RFC diff. Based on #8724 to keep this review focused on the research search scenario.

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>

@loopx-agent loopx-agent left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewer: model_agent · gpt-6.1-sol · OpenAI · runtime_reported · reasoning_effort=max

Approval conclusion (author-owned PR; GitHub blocks formal self-approval)

评审提交 a3f83fa9e64a06c47589b6f74973d9c8c229c027,目标分支基线 3d1548419676505c57ef96b283bd25a0c64d7c26。

动机 / Motivation

这项改动面向维护 Dashboard 覆盖报告的贡献者,也验证工作区读者使用的搜索入口。 旧版搜索场景在两个运行模式都打开编译产物。基线走完浏览器断言后以「没有映射到 Dashboard 源码」退出。 候选源码和打包场景均通过真实分页后端验证。源码报告在 research-record-browser.tsx 记录 111/146 条语句和 6/9 个函数的执行。 在隔离的原生分页后端和合成研究记录上运行。未跑完整 Dashboard 覆盖矩阵、已安装 App 或托管 CI。#8724 仍是开放的目标分支。

改动思路 / Approach

沿用同一个浏览器场景和一次性的原生历史后端。源码模式打开 Vite,复用现有代理转发同源数据请求。打包模式打开该后端提供的编译页面。页面入口与数据代理 原代理

具体改动 / Changes

关键代码讲解

中断后续分页的注入只截获带 cursor 的读取,其余请求交给已有路由。最后检查真实分页读取次数、源快照和 mutation 计数。源码模式再核对搜索模块的执行范围,才将样本交给报告。不同 Goal 的空结果、旧记录的搜索与导出和部分读取恢复仍走同一个场景。分页注入 后端与覆盖回读

基线 docs/architecture/rfcs/goal-workspace-surface-v0.md 的 源码分线覆盖 与 共同后端与只读行为 都有实测。已有搜索、导出和版本单测覆盖纯逻辑;此处继续用原场景验证真实入口。相邻 #8724 负责 Vite 端口归属。基线验收依据 Smoke 保留条件

对主干的风险 / Risks

插桩依赖当前 Vite 模块路径,路径移动会使场景失败并要求同步更新。打包搜索、已有导出、恢复和同源隔离通过。改动没有新增场景,且只在触发覆盖的分线要求搜索组件范围。

语义与 CI 对齐

独立运行了基线与候选源码覆盖、候选打包场景和本地 standard premerge。11 项检查均通过,包括 RFC 双语检查。

我的整体评价 / Verdict

批准当前提交。覆盖报告具备了搜索经过真实源码入口的证据,两个入口均有后端只读回读。

English verdict: APPROVE at a3f83fa. The existing scenario now exercises mapped Dashboard search source while preserving native paged readback and the packaged recovery path.

@loopx-agent
loopx-agent deleted the branch codex/audit-dashboard-startup-pr-20261114 November 14, 2026 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant