Skip to content

Verify task apply refusal at its visible workspace status - #8753

Merged
huangruiteng merged 1 commit into
mainfrom
codex/workspace-create-refusal-smoke-20261114
Nov 14, 2026
Merged

huangruiteng merged 1 commit into
mainfrom
codex/workspace-create-refusal-smoke-20261114

Conversation

@loopx-agent

Copy link
Copy Markdown
Collaborator

The packaged workspace smoke waits for the failed-apply message inside the confirmation drawer. When apply returns HTTP 503 and the original preview is still available, the workspace keeps the preview and shows the error in its live status region.

The smoke now checks the visible refusal, confirms the draft is retained and no task row appears, then retries with one confirmation. The real Todo backend and a separate CLI read verify that recovery creates exactly one task at the default P1 priority.

The previous assertion timed out against the packaged candidates from #8266 and #8748. The updated scenario passed locally using the installed wheels from both runs. Node syntax and Git whitespace checks also passed.

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>

@loopx-agent loopx-agent left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewer: model_agent · gpt-6.1-sol · OpenAI · runtime_reported · reasoning_effort=max

Approval conclusion (author-owned PR; GitHub blocks formal self-approval)

评审提交 443749dba16df97c48a3694400e089ddd37f7918,目标基线 dd53ca52184cb6283e4728301fa996f8cd7b2ca0。未发现阻塞问题。

动机 / Motivation

这项检查保护在工作区创建任务并从网络错误恢复的用户,也让维护者能区分真回归和测试误报。 例如点击“确认并应用”遇到 HTTP 503:页面已经报告错误、原草稿仍在,旧测试却在抽屉里等到超时,并阻断后续恢复验证。 我用相同产品源码重建两个提交的打包页面:旧测试在等错误提示时超时,新测试读到状态提示、确认草稿还在,恢复后由 CLI 读回恰好一条默认 P1 的任务。 本 PR 只更新现有浏览器检查,产品源码、状态规则和权限不变。

改动思路 / Approach

保留现有场景和后端夹具。工作区读取原 preview:它仍有效时,抽屉显示预览,网络错误由页面状态区提示。测试在这两个各自可观察的边界判断结果。失败后的原预览读回、工作区状态区。

具体改动 / Changes

关键代码讲解

  • 注入失败和计数:首次 apply 明确返回 503,且不转发给真实后端。等状态区出现本次错误后检查没有任务行,再关闭抽屉核对原始文本。
  • 恢复与独立读回:恢复转发后重新打开预览,只按一次“确认并应用”;必须看到任务行、草稿清空和两次总请求。CLI 从同一隔离后端读回一条任务和默认 P1。
  • 按 docs/development/good-smokes.md 在 dd53ca52184cb6283e4728301fa996f8cd7b2ca0 的要求,visible-refusal 已覆盖用户可见的错误和草稿,recovery-creates-once 已覆盖独立读回。原有 Unicode 边界和规范化检查仍在。

对主干的风险 / Risks

旧测试只在确认抽屉里等“失败”,产品实际把这次传输错误放到了页面状态区。 旧场景在相同产品源码的打包版超时 30 秒;头提交通过同一场景。此次更新复用现有打包和发布入口。相邻 Chat 恢复检查关注投递或读回;这里的创建失败和一次重试仍由一处场景覆盖。标准 premerge 的 4 项直接检查、2 项 catalog 检查和公开边界扫描通过,另外通过 Node 语法检查。

我的整体评价 / Verdict

同意这次测试修正。失败先由用户能看到的状态验证,成功再从实际 Todo owner 查证,因此可以防止恢复逻辑或测试误报再次掩盖真实结果。本次是本地重建的打包页面和隔离 File 后端。HTTP 503 在服务收到写入前注入;未验证已经提交但回复丢失、已安装 App 或远端 CI。

English verdict: APPROVE. The packaged smoke observes the existing live refusal state, preserves the draft and verifies one task after a single retry through the real Todo owner.

@huangruiteng
huangruiteng merged commit f5383cb into main Nov 14, 2026
34 of 44 checks passed
@huangruiteng
huangruiteng deleted the codex/workspace-create-refusal-smoke-20261114 branch November 14, 2026 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants