Skip to content

fix(native-chat): reuse owner Goal checks for managed Tasks - #8795

Merged
cocolord merged 1 commit into
mainfrom
codex/r1-native-goal-validation-20261114t193545
Nov 14, 2026
Merged

cocolord merged 1 commit into
mainfrom
codex/r1-native-goal-validation-20261114t193545

Conversation

@cocolord

@cocolord cocolord commented Nov 14, 2026 •

Copy link
Copy Markdown
Member

Managed Native Tasks currently stop when they have owner-configured Goal checks but no duplicate Task argv declaration. This change lets the existing Native Session consume the canonical Goal/Task validation plan, running every applicable Goal check and required Task check before committing.

The shared TypeScript owner composes the checks. Python reads the current canonical basis and private declarations, invokes the existing runners, and checks definition, work, claim, lifecycle and verifier assets before and after validation. Todo argv retains typed-result stdin and the existing receipt; legacy non-argv declarations retain the unavailable boundary. Missing, corrupt, stale or unbound required sources cannot fall back to weaker validation.

关联 RFC / RFC alignment: minimal-kernel distribution RFC, V2/V4/R1, with its English/Chinese checkpoint updated together. This removes duplicate setup for checks already approved by the owner. First-Goal trusted-checker binding, automatic first-Task adoption, complete D2/D5 closure and full V1–V5/V10 acceptance remain open. C1 coordination: #8266; predecessor admission recovery: #8792.

Validation:

  • Prior Native consumer reproduces the Goal-only refusal in both File/SQLite route variants.
  • Shared TS: 99 related tests, 54 baseline compatibility vectors, strict scoped typecheck and a real-handler definition-hash mutation pass.
  • Native: the full 91-case cohort passes, plus four final scope/recovery cases; original Session, HTTP/replay, source changes and independent-failure paths are exercised.
  • Current C1: frozen-production Native91 passes and a newly rebuilt Core39 installation suite passes. Installed handler dispatch is verified against the new shared-plan bytes; final scope/source readback is verified (95 Native cases total), pinned to C1 71ccd34c39ca5777b9de9cadc07afd5239e5324c.
  • Bilingual RFC staged check, Python syntax, semantic advisory and full-tree vocabulary smoke pass.
  • Full-tree TypeScript typecheck has an existing error at tests/control_plane_ts/coordination_runtime_shadow.test.ts:380; that file is byte-identical to the base. The affected production files and new TS test pass strict typecheck.

Review corrections retained: successful Goal receipts omit failure recovery, ordinary command receipts use a safe summary fallback, and non-argv required Todo declarations preserve refusal. Final standard premerge (6 direct + 11 selected), Native, C1 and fresh Core qualifications pass. Exact-head review and merge readiness are recorded separately; this is a bounded R1 increment.

Signed-off-by: lusendong.6789 <lusendong.6789@bytedance.com>
Signed-off-by: lusendong.6789 <lusendong.6789@bytedance.com>
Co-authored-by: TRAE CLI <traecli@bytedance.com>
@cocolord
cocolord force-pushed the codex/r1-native-goal-validation-20261114t193545 branch from fad80d5 to 7f74fb7 Compare November 14, 2026 20:21

@cocolord cocolord left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewer: model_agent; GPT-6 family; OpenAI; self_reported.

Approval conclusion (author-owned PR; GitHub blocks formal self-approval)

动机 / Motivation

已配置 Goal 检查、通过原 Native Session 推进 Task 的用户会遇到这个问题。同一 Task 原先因缺少重复的 argv 声明停止;现在直接消费 owner 已批准的 Goal 检查,所有必需 Task 检查仍要通过。已配置的独立检查真正参与原 Task 执行、提交和结果读回,重试原操作不会重新派发模型。本批不生成或安装新 Goal 的可信检查器,不授权 browser 或模型提供执行命令。首个自然语言 Goal 的可信检查来源绑定、自动采用、完整闭包和完整成本仍未完成。

改动思路 / Approach

组合规则从既有 canonical owner 提取,Native 只读来源并执行既有检查器,避免复制 Python 决策或建立第二套 C1 管线。本批完整交付已批准 Goal 检查的 Native 消费与失败恢复;首次可信来源绑定和全目标验收继续留在原 R1。准入、lease、执行和结算仍由原 Session 与 Turn owner 完成。TypeScript 只组合当前 canonical 检查;Python 只读取真实来源、检查资产并调用既有 runner。保留 Task argv 的原结果 stdin 和严格 receipt,比复制 Goal 声明到每个 Task 或增加 Python 判断分支更直接。

具体改动 / Changes

规格依据为 docs/architecture/rfcs/monorepo-distribution-split-v0.md,按变更前提交 48dbebbd14c5535b9631f4c7a1152d86aa64c5b2 评审。V2 的范围、必需检查与单次结算在本批受检路径上得到验证,完整预设 parity 仍 deferred;V4 的原 Session、已确认操作读回与恢复被保留,真实模型及完整恢复成本仍 deferred。V5 的模型 context/compaction、V10 的完整成本,以及 R1 的完整组合资格均 deferred,继续沿原验收推进。新增 ledger 是双语、非规范性进展记录,没有把本批结果写成整目标完成。

关键代码讲解

  • canonicalTaskValidationPlan 要求当前完整 Todo 和显式 owner scope;Goal 与必需 Task 检查累加。缺失或损坏的必需声明不能被 Goal 成功替代。Delegation wrapper 保留旧诊断和 oracle provenance。
  • _validation_source 读取真实 canonical owner、digest 选中的私有声明和当前 checker 资产;owner 读取失败、适用但未绑定或过期都不能冒充 null。
  • prepare_validation 用既有 Goal runner 执行 criterion,用原 argv validator 传递 typed-result stdin。成功 receipt 不带失败 recovery 标记;普通命令缺少 summary 时使用安全摘要;旧非 argv Task 声明继续停止。
  • validator 在检查前后复核定义、工作、认领、生命周期和资产。已通过的旧检查不能覆盖后来变更的来源;无关 note/progress 不会被误当作工作变更。

对主干的风险 / Risks

最强反例是 Goal 成功掩盖必需 Task 失败,以及选定范围误捕获后来独立 Task。现有真实 Native/HTTP 回归、stdin exit-1 和范围恢复序列都验证了这两个方向;checker 或工作在验证后变更,也不能写状态或扣额。独立评审发现三个 receipt/argv 缺陷,已修复并保留对应回归。模型和 Codex provider 为合成协议,Chat、Core、canonical authority、argv 与文件检查为实际路径。

当前完整 Native cohort 91 项 PASS,另四项最终 scope/Goal-work 回归 PASS;共享 TS99 项、54 组基线完整结果/诊断 parity、定义哈希 mutation 和严格 scoped typecheck PASS。最终提交标准 premerge 的 6 个 direct 与 11 个 selected 检查 PASS;同 C1 71ccd34c39ca5777b9de9cadc07afd5239e5324c 组合的 Native 91+4 项及新 Core 安装 39 项 PASS;准确组合 tree 为 d2bc4abe84b3955baa0e55516c7650641cd7019a。实际安装 handler 的 8 项 owner-store 计划及 2 项无效范围拒绝 PASS,新的 wheel 与 1,897 个 payload 文件来源一致。模型 provider 为合成边界,不把源码/安装资格外推为完整原生模型证据。远端 CI 与 merge readiness 单独读回,未声称全绿。

语义与 CI 对齐

本批复用现有 canonical 验证词汇、acceptance work-field 分类和严格 Turn receipt,没有新状态 owner、迁移或公共执行授权。双语 RFC、语义 advisory 与完整 vocabulary smoke PASS。全树 TypeScript 的 coordination_runtime_shadow.test.ts:380 错误位于未触及文件;同依赖、同命令的不可变 base/head 对照均仅此一个 TS2345,完整日志字节相同;严格 scoped typecheck PASS。因此保留其失败并归为 pre_existing_unrelated,没有放宽检查或修改未触及测试。

我的整体评价 / Verdict

这是一项有实际调用方和完成结果的 justified increment:已批准检查被原 Task 消费,额外重复声明轮次消除;长程续行与用户路径在限定场景 improved,完整效果和成本不作外推。组合规则从既有 canonical owner 提取,Native 只读来源并执行既有检查器,避免复制 Python 决策或建立第二套 C1 管线。本批完整交付已批准 Goal 检查的 Native 消费与失败恢复;首次可信来源绑定和全目标验收继续留在原 R1。steward_managed_mode.py 与现有 native-turn HTTP 路径只改变验证消费,不改变渲染页面或布局。无新增渲染评审范围。准确 head 为 7f74fb7a032fb4400c1320f2bf1ea6c364d751ce。没有未解决的 blocking finding,当前准确 head 可 APPROVE。现有全树 typecheck 失败已有独立归因,CI/分支保护和授权合入决定分别记录;可信首次检查来源、真实模型和完整 R1/M3 仍是原目标缺口。

English verdict: APPROVE. No blocking findings remain at this exact head. Native Tasks reuse owner-approved Goal checks while preserving required Task checks, scope/source fences and original authority. Current C1 and fresh Core qualifications pass; full-tree TS failure is independently pre-existing. First-Goal trusted-checker binding and full R1 acceptance remain open; merge readiness is separate.

@cocolord

Copy link
Copy Markdown
Member Author

Authorized merge decision for exact head 7f74fb7a032fb4400c1320f2bf1ea6c364d751ce.

The complete author-owned approval review is published at #8795 (review) and its exact commit/body were read back. There are no unresolved review threads or current blocking findings. Local qualification passes: Native91 + final scope4, current C1 Native95, fresh Core39, installed handler8 owner-store plans +2 scope refusals, shared TS99 and54 baseline compatibility vectors, final scoped typecheck, bilingual/semantic checks, and standard premerge6 direct +11 selected checks. The same final Goal-only inputs fail on the immutable base and pass on the candidate. Full-tree TS2345 is independently reproduced with identical diagnostics/logs on base/head; it remains disclosed.

Merge readiness is false solely for pending/incomplete CI (17 success,27 pending,0 failures at the recorded check). The unchanged head is open and mergeable, with valid exact-head approval and complete threads. Using the existing maintainer authorization to merge positive, reviewed work, admin bypass overrides this readiness/GitHub policy hold. This does not label remote CI green or complete the original R1/model/context/full-cost acceptance.

@cocolord
cocolord merged commit 6dfd1c9 into main Nov 14, 2026
25 of 49 checks passed
@cocolord
cocolord deleted the codex/r1-native-goal-validation-20261114t193545 branch November 14, 2026 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant