Skip to content

Assert that the coordination lease probe emitted JSON - #8796

Merged
huangruiteng merged 1 commit into
mainfrom
codex/coordination-lease-probe-typecheck
Nov 15, 2026
Merged

huangruiteng merged 1 commit into
mainfrom
codex/coordination-lease-probe-typecheck

Conversation

@loopx-agent

Copy link
Copy Markdown
Collaborator

Goal And Delivered Outcome

TypeScript CI rejects the coordination lease probe because the last stdout line can be absent. Assert that the probe emitted an observation before parsing it. If a successful child emits no observation, the test now explains what is missing. Production code is unchanged.

This extracts the existing fix from #8266 so other branches can take it independently. The type-check failure on #8791 reproduced on current main with the same TypeScript version.

  • Intended base: main.
  • Written by Codex, OpenAI.

Validation

  • Without the patch: npm run typecheck:control-plane reports TS2345 at the test's JSON.parse call.
  • With the patch: the same full type-check passes; all 24 coordination runtime shadow tests pass, including the Windows lease metadata scenarios executed through isolated subprocess simulation. No native Windows run was performed locally.
  • Diff and bilingual RFC checks pass. No paired RFC, product surface, or generated fixture changed.

Scope And Continuation

Test only. Once the fix is on main, the benchmark Stop hook PR can renew its base and rerun its checks without taking the C1 changes.

Frontend / Visual Evidence

No user-facing UI change.

Type of Change

  • Test update

Boundary Checklist

  • Public-safe test change and validation only.
  • Commit has a DCO sign-off.

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>
(cherry picked from commit 2c099be)
Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>

@loopx-agent loopx-agent left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewer: model_agent · gpt-6.1-sol · OpenAI · runtime_reported · reasoning_effort=max

Approval conclusion (author-owned PR; GitHub blocks formal self-approval)

评审提交 114ebe643ee9427b7378f65f3a51c202de360fe6,目标基线 6dfd1c90c4c1a186c43de0a2c05243fa14b5a76e。

动机 / Motivation

受影响的是运行控制面类型检查、验证协调存储改动的维护者。 主干直接解析子进程的最后一行;编译器认为这一行可能不存在,因而阻断校验。候选先确认子进程给出了观察结果,再解析同一行。 候选通过同一套类型检查;若子进程成功退出却没有输出,测试仍会失败,并说明缺少观察结果。 只修现有测试入口,生产 lease 逻辑、权限和持久状态均未变化。未在原生 Windows 上运行。

改动思路 / Approach

沿用原有四组子进程测试。测试先核对退出码,再确认最后一行存在。结果仍由同一个生产 bootstrap 生成;测试继续断言适用的状态、拒绝原因和文件元数据重查次数。单独提交这一处让其他分支能先恢复类型检查,无须采用 #8266 的运行时改动。

具体改动 / Changes

唯一改动 增加 assert.ok(resultLine)。它同时将类型缩成 string,并在本地执行时报告明确的缺输出错误。没有移除断言,也没有新建 smoke。与 #8266 当前头这份文件逐字一致。按 docs/development/testing-and-quality.md 的编译和测试边界,explicit-test-typecheck 与 control-plane-runtime-suite 均已验证。

对主干的风险 / Risks

Node 24.21.0、TypeScript 6.0.3:base 仅在 JSON.parse 报 TS2345,head 通过相同的全量类型检查;两边协调 shadow suite 各 24/24。 将四个场景的观察子进程替换成退出码 0 且无输出的真实 Node 进程。候选各报观察缺失,base 各报 Unexpected end of JSON input;两边均拒绝。 标准 premerge 四项直接检查通过,包括成对 RFC 差分。类型检查修复与 lease 运行行为分开验证;Windows 元数据场景使用隔离子进程模拟平台,未声称原生设备覆盖。未查询托管 CI。

我的整体评价 / Verdict

批准此精确头。长期维护仍使用同一观察和断言,失败诊断更清楚;检查的是测试输出和编译结果,未改动任何面向用户的页面或消息。 本评审结论保留受保护合并的独立边界。

English verdict: APPROVE at 114ebe6. The existing shadow tests still enforce the same lease behavior, and TypeScript 6.0.3 accepts the guarded probe output.

@huangruiteng
huangruiteng merged commit 595582d into main Nov 15, 2026
27 of 37 checks passed
@huangruiteng
huangruiteng deleted the codex/coordination-lease-probe-typecheck branch November 15, 2026 05:16
loopx-agent added a commit that referenced this pull request Nov 15, 2026
…000 commits (#8759)

* Deliver verified images in private Lark answers

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>

* Keep image retries behind new private Lark replies

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>

* Recover missing images from one verified private Lark reply

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>

* Use one wall clock for private Lark image retries

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>

* Recheck the original Lark reply before historical image writes

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>

* Verify private Lark image sources before every redirect

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>

* feat(coordination): add postgresql authority checkpoints and local-to-pg-seed exporter

- Add authority_checkpoints table DDL and tenant-scoped RLS policies.
- Store incremental delta in authority_commits and bounded checkpoints every 64 commits and on genesis cursor 1, resolving table bloat and the 20,000 commit recovery ceiling.
- Implement scanCommitted bounded delta replay from covering checkpoint via AuthorityStateReplay.
- Add setupPostgreSqlAuthoritySchemaAndRole for explicit schema installation and least-privilege restricted role assembly.
- Add exportLocalToPgGenesisSeed with sanitization (expired leases, local absolute paths, .local/ references, Feishu IDs, private materials) and fail-closed privacy boundary scan.
- Add loopx postgres setup and loopx postgres local-to-pg-seed CLI commands.
- Add test suites for checkpoints, sanitization, role assembly, and CLI invocation.

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>

* Recheck the historical Lark reply before each media write

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>

* Retry Lark image uploads after an explicit App scope rejection

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>

* Honor original Lark stop and closure before deferred images

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>

* Recheck private answer control after Lark source read

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>

* Read the current Core session after delayed image controls

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>

* Fence private answer media dispatch with original controls

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>

* Keep Lark media checks with private delivery

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>

* Recheck Lark image sources after recording upload intent

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>

* Read both original Feishu messages together before media upload

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>

* Verify Feishu sources at the guarded image dispatch

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>

* Preserve pre-dispatch Feishu source and session validation

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>

* Recover and verify PostgreSQL checkpoint history with append-only privileges

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>

* Verify backup history to its captured cursor beyond 20000 commits

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>

* Generate explicitly synthetic secret fixtures at test time

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>

* Recover private image uploads when the Lark CLI cannot start

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>

* fix(chat): preserve the first Goal's registered conversation (#8798)

* fix(chat): preserve the first Goal's registered conversation

Signed-off-by: lusendong.6789 <lusendong.6789@bytedance.com>
Co-authored-by: TRAE CLI <traecli@bytedance.com>

* test(chat): keep original Goal adoption compatible with Python 3.11

Signed-off-by: lusendong.6789 <lusendong.6789@bytedance.com>
Co-authored-by: TRAE CLI <traecli@bytedance.com>

---------

Signed-off-by: lusendong.6789 <lusendong.6789@bytedance.com>
Co-authored-by: TRAE CLI <traecli@bytedance.com>

* Avoid rereading delivered Lark settings records and empty queues

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>

* Recover private Lark images after a CLI descriptor limit

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>

* Enable existing checks and the original authorized Task in managed Chat

Signed-off-by: lusendong.6789 <lusendong.6789@bytedance.com>
Co-authored-by: TRAE CLI <traecli@bytedance.com>

* Reuse the canonical boundary projection and narrow Task JSON types

Signed-off-by: lusendong.6789 <lusendong.6789@bytedance.com>
Co-authored-by: TRAE CLI <traecli@bytedance.com>

* Keep confirmed Goal creation attached to its original Task (#8805)

Reuse the existing C1 source observation guard

Signed-off-by: lusendong.6789 <lusendong.6789@bytedance.com>
Co-authored-by: TRAE CLI <traecli@bytedance.com>

* Assert the lease source probe returned an observation (#8796)

(cherry picked from commit 2c099be)

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>

* Recover an owed replan debit before the next host Turn (#8794)

* Recover an owed replan debit before the next host Turn

Consider the original Todo binding when an admitted replan has verified writeback. Require the exact spend receipt before another guard grants delivery, even if the Todo lifecycle has changed. Keep explicit selection on the same recovery path and let the existing settlement owner replay the original debit.

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>

* Preserve ordinary completed-Todo successor admission

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>

* Replay one validated Turn debit across concurrent observations

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>

* Validate original Turn spend terms before debit and replay

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>

---------

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>

* Keep conversation history rendering off the typing path (#8781)

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>

* feat(coordination): complete remote task lifecycle and opt-in gateway access (#8747) (#8765)

* feat(coordination): add complete remote task lifecycle and opt-in gateway access (#8747)

Align with PR #8747 (multi-loopx-agent-cloud-collaboration-v0) and
remote-authority-task-service-v0 (#8508):

1. Extend RemoteAuthorityService with full remote task settlement:
   - Add 'complete', 'block', 'defer', 'todo_add', and 'snapshot' operations.
   - Enforce hard-lease fencing and claim-request ownership checks.
   - Settle completion receipts and deterministic cross-machine snapshot digests.
   - Maintain default-deny Tenant/Goal/Actor authorization and incarnation pinning.

2. Introduce controlled remote authority gateway in Python control plane:
   - Default-disabled access: local private Goals never connect to remote
     authority or leak local credentials.
   - Opt-in gateway metadata projection for explicitly configured goals and
     the 'loopx-quality-review' canary.
   - Fail-closed should-run health check when remote authority is unconfigured
     or unreachable.

3. Conformance and unit test coverage across TypeScript and Python suites.

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>

* test(coordination): assert subprocess readback before decoding

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>

* fix(coordination): qualify explicit remote task reads and lifecycle receipts

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>

* fix(coordination): preserve existing successors on remote completion

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>

* test(remote-authority): prove ordinary admission stays local

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>

---------

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>

* test(chat): preserve create-only intent in workspace selection smoke

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>

* Defer material inventory during configuration discovery (#8807)

Signed-off-by: lusendong.6789 <lusendong.6789@bytedance.com>
Co-authored-by: TRAE CLI <traecli@bytedance.com>

* Defer report providers during Turn reads

Signed-off-by: lusendong.6789 <lusendong.6789@bytedance.com>
Signed-off-by: lusendong.6789 <lusendong.6789@bytedance.com>
Co-authored-by: TRAE CLI <traecli@bytedance.com>

* test(core): require installed provenance before qualification

Signed-off-by: lusendong.6789 <lusendong.6789@bytedance.com>
Co-authored-by: TRAE CLI <traecli@bytedance.com>

* Reuse the final source check for staged Turn requests (#8820)

Signed-off-by: lusendong.6789 <lusendong.6789@bytedance.com>
Co-authored-by: TRAE CLI <traecli@bytedance.com>

* Defer PR wait provider loading until permission is checked (#8821)

Load the optional PR reconciler only after the invocation-time observation permission check, inside the existing provider failure boundary. Preserve original permission, cadence, result and unknown-effect owners, and document the bounded default-closure and timing-window change.

Signed-off-by: lusendong.6789 <lusendong.6789@bytedance.com>
Co-authored-by: TRAE CLI <traecli@bytedance.com>

* Load provider options only for the selected capability editor (#8822)

Signed-off-by: lusendong.6789 <lusendong.6789@bytedance.com>
Co-authored-by: TRAE CLI <traecli@bytedance.com>

* docs: describe README session continuity directly (#8823)

* Skip automatic usage observers for supported opt-outs (#8824)

* Skip automatic usage observers for supported opt-outs

Signed-off-by: lusendong.6789 <lusendong.6789@bytedance.com>
Co-authored-by: TRAE CLI <traecli@bytedance.com>

* Record installed Core and C1 observer qualification

Signed-off-by: lusendong.6789 <lusendong.6789@bytedance.com>
Co-authored-by: TRAE CLI <traecli@bytedance.com>

---------

Signed-off-by: lusendong.6789 <lusendong.6789@bytedance.com>
Co-authored-by: TRAE CLI <traecli@bytedance.com>

* docs(blog): add EdgeBench controlled Context ON vs OFF 10-task score comparison (#8760)

* docs(blog): add EdgeBench controlled Context ON vs OFF 10-task score comparison

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>

* docs(blog): use declarative mechanism-led opening in zh context-delivery score section

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>

---------

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>

* fix(heartbeat): preserve proven waits before their due time (#8825)

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>

* Fix manager discovery in ordinary installs (#8830)

* Package the manager discovery projection

Signed-off-by: lusendong.6789 <lusendong.6789@bytedance.com>
Co-authored-by: TRAE CLI <traecli@bytedance.com>

* Record selected manager discovery distribution qualification

Signed-off-by: lusendong.6789 <lusendong.6789@bytedance.com>
Co-authored-by: TRAE CLI <traecli@bytedance.com>

---------

Signed-off-by: lusendong.6789 <lusendong.6789@bytedance.com>
Co-authored-by: TRAE CLI <traecli@bytedance.com>

* test(workspace): verify confirmed Goal creation against the current contract (#8816)

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>

* Fix Windows CLI output probe reader invocation (#8817)

Port the probe fixture and native Windows regression coverage from e6eb92d and 8d200aa. Decode the generated PowerShell literals into argv before launching the pinned reader.

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>

* refactor(issue_fix): fold reviewer source trust/freshness vocabularies into one owner (#8826)

reviewer_recommendation.py restated the trust and freshness sets that
repository_context.py already owns. Import both as aliases of the owner
objects so the decision has a single source, and add an architecture guard
that pins single ownership by value, by identity, and by wiring through both
public builders. REVIEWER_SOURCE_KINDS stays local (deliberately narrower).

Signed-off-by: psychologister <230141834+psychologister@users.noreply.github.com>
Co-authored-by: psychologister <230141834+psychologister@users.noreply.github.com>

* fix(scheduler): reject superseded heartbeat receipts on the Python follow-up route (#8708)

* fix(scheduler): reject superseded heartbeat receipts on the Python follow-up route

The Python compatibility route for scheduler-ack-current/scheduler-fail-current
checked only that the receipt for --turn-instance-id exists; a receipt already
superseded by a newer heartbeat Turn still committed scheduler state, while the
native TypeScript transaction rejects it as heartbeat_receipt_stale.

Thread the Turn from build_scheduler_followup_payload through
record_quota_scheduler_ack / record_quota_scheduler_ack_for_decision /
record_quota_scheduler_failure_for_decision into _run_native_followup, which now
sends turn_instance_id with require_heartbeat_receipt=true. The TypeScript
transaction remains the single owner of the missing/stale/superseded fence (it
also rechecks under the scheduler state lock); optional parameters keep the
in-process API, which has no Turn, unchanged.

Fixes #8605

Signed-off-by: Lihua <1017343802@qq.com>

* Keep scheduler follow-up hint reads out of legacy migration

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>

---------

Signed-off-by: Lihua <1017343802@qq.com>
Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>
Co-authored-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>

* Resume the original quota settlement after lifecycle writeback (#8728)

* fix(replan): resume settlement after lifecycle review writeback

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>

* Recover committed replan settlement before rebuilding its review

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>

---------

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>

* fix(antigravity): keep the project registry in generated wakes (#8768)

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>

* fix(chat): keep workspace checker reads portable (#8814)

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>

* Reject external Turn retries when the captured work changes (#8828)

* Recheck captured work before launching an external Turn host

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>

* Keep complete-source metadata assembly outside Turn planning

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>

---------

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>

* Preserve PostgreSQL runtime access and recover seed output retries

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>

* Validate recovery cursor metadata without a fixed history ceiling

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>

---------

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>
Signed-off-by: lusendong.6789 <lusendong.6789@bytedance.com>
Signed-off-by: psychologister <230141834+psychologister@users.noreply.github.com>
Signed-off-by: Lihua <1017343802@qq.com>
Co-authored-by: Lusen Dong <lusendong.6789@bytedance.com>
Co-authored-by: TRAE CLI <traecli@bytedance.com>
Co-authored-by: Lusen Dong <cicomaple@gmail.com>
Co-authored-by: psychologister <st040325@gmail.com>
Co-authored-by: psychologister <230141834+psychologister@users.noreply.github.com>
Co-authored-by: Lihua <1017343802@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants