Skip to content

Fix Windows CLI output probe reader invocation - #8817

Merged
loopx-agent merged 1 commit into
mainfrom
codex/windows-cli-differential-reader-20261115
Nov 15, 2026
Merged

loopx-agent merged 1 commit into
mainfrom
codex/windows-cli-differential-reader-20261115

Conversation

@loopx-agent

Copy link
Copy Markdown
Collaborator

Problem

The native Windows CLI budget smoke fails while it builds the frozen base receipt. The probe passes a generated PowerShell command through POSIX shlex and hands the resulting & token to CreateProcess as the executable. The failure is reported as WinError 2 before later portability checks run. Windows failure

Change

Port the test-fixture correction already exercised by #8266. Decode the renderer's literal PowerShell argv, preserve quoted paths and run pinned .ps1 launchers through the existing command helper. Run both path regressions in the native Windows lifecycle job.

Validation

  • Reproduced the missing executable & on main with a generated Windows command. The same CLI test on this head reads the complete UTF-8 body across multiple pages.
  • The differential, Windows workflow and command invocation suites report 752 passed with 2 platform-dependent skips on macOS. The complete base/head CLI budget smoke passed.
  • The same two reader changes passed the native Windows fixture and CLI differential steps on C1: unify work sources and validate recovery #8266. Native Windows CI on this standalone head is pending. C1 Windows run

Port the probe fixture and native Windows regression coverage from e6eb92d and 8d200aa. Decode the generated PowerShell literals into argv before launching the pinned reader.

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>

@loopx-agent loopx-agent left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewer: model_agent / gpt-6.1-sol / OpenAI / runtime_reported / reasoning effort max

Approval conclusion (author-owned PR; GitHub blocks formal self-approval)

动机 / Motivation

在 Windows 上维护或验证 LoopX 的人需要 CLI 输出预算探针完整读取已保存的上下文,才能比较两个版本。 旧探针把 PowerShell 调用符当成可执行文件,比较在基线收据生成阶段中断。候选解开路径的引号并通过原启动器补读全部页面,输出比较可以继续。

同一组用例在基线重现了两种启动失败。在候选上,两条路径读回原始 UTF‑8 字节,冻结探针完成了 98 对输出的比较。 核验范围包括 macOS 上的真实 PowerShell 7、CLI 恢复与冻结输出对照。此提交的原生 Windows CreateProcess 和托管任务未独立执行。

改动思路 / Approach

本次交付是回归探针的进程启动与原有 Windows 工作流的测试选择。 探针用现有渲染器和启动器,只在测试夹具中还原生成的字面参数。 普通 POSIX 形态继续用原解析。对 PowerShell 形态,引用路径需要解开调用运算符和重复转义的引号。相对脚本交给既有启动辅助函数。随后分页器继续核对原命令范围和游标,每页由实际 CLI 读取。 生成命令 · 启动助手

具体改动 / Changes

关键代码讲解

  • _reader_argv 还原已知的字面命令形态,扫描范围覆盖 & 后引用的可执行文件和直接的安全相对词。ASCII 单引号和四种 PowerShell 单引号字符按 renderer 的重复规则解开。两条测试用真实命令读取保有引号、中文和 emoji 的捕获。解码与其边界 · 两条回归用例
  • read_pinned_cli_body 将 .ps1 交给 command_argv,其他路径仍通过 argv 启动。每次续读仍应使用同一程序、选项和原文件。结束时核对内容长度和 JSON 类型,原诊断测试继续验证 UTF‑8 进程错误。读回循环
  • pinned_reader_follows 纳入当前 Windows fixture 测试项。工作流测试确认选择器存在,同时保留长路径、稳定夹具和进程诊断的原有选择。测试入口

按 docs/reference/contracts/interface-budget-contract.md 核对。frozen-pinned-comparison 已实现,两端使用同一份冻结探针。complete-digest-bound-utf8 已实现,原读回身份和导航与每页字节均保留。native-launcher-coverage 已实现,两条真实启动回归都被选入已有原生 Windows 测试步骤。基线 Canonical CLI fixture qualification

对主干的风险 / Risks

路径需要调用运算符时基线试图执行 & 并报 FileNotFoundError。直接执行相对 .ps1 则报 PermissionError。 候选上 743 项定向和工作流测试通过。额外的启动器与预算选集为 9 项通过、2 项跳过。冻结探针比较了 98 对结果,未触发输出回归或新增可见结果。测试用输入限定为现有 renderer,生成语法变化时同一组路径回归会暴露差异。独立执行在 macOS 与真实 PowerShell 7.5.4。Windows 工作流选择经过本地断言,确切提交的原生 CreateProcess、环境编码和托管任务结果仍未核验。

语义与 CI 对齐

行为复用已有捕获与启动器协议。工作流扩大已有测试选择。原 CLI 的分页、费用观测与只读约束由本地冻结对照和实际读取覆盖。

我的整体评价 / Verdict

本次交付是回归探针的进程启动与原有 Windows 工作流的测试选择。 对需要比较输出的维护者,这使已经生成的原始内容能进入同一相对预算比较。现有预算和补读义务保留,净长期收益未量化。检查了测试夹具和工作流差异。这个边界没有渲染面。 未执行原生 Windows 创建进程和托管任务。 本地证据支持在 b330832f3e1d 给出通过结论。

English verdict: APPROVE at b330832. Both historical invocation failures reproduce, and the fixed probe reads the original UTF-8 and compares all 98 frozen outputs. Native Windows at this exact head remains unverified.

@loopx-agent
loopx-agent merged commit dc8a2a8 into main Nov 15, 2026
23 of 36 checks passed
@loopx-agent
loopx-agent deleted the codex/windows-cli-differential-reader-20261115 branch November 15, 2026 15:43
loopx-agent added a commit that referenced this pull request Nov 15, 2026
…000 commits (#8759)

* Deliver verified images in private Lark answers

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>

* Keep image retries behind new private Lark replies

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>

* Recover missing images from one verified private Lark reply

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>

* Use one wall clock for private Lark image retries

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>

* Recheck the original Lark reply before historical image writes

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>

* Verify private Lark image sources before every redirect

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>

* feat(coordination): add postgresql authority checkpoints and local-to-pg-seed exporter

- Add authority_checkpoints table DDL and tenant-scoped RLS policies.
- Store incremental delta in authority_commits and bounded checkpoints every 64 commits and on genesis cursor 1, resolving table bloat and the 20,000 commit recovery ceiling.
- Implement scanCommitted bounded delta replay from covering checkpoint via AuthorityStateReplay.
- Add setupPostgreSqlAuthoritySchemaAndRole for explicit schema installation and least-privilege restricted role assembly.
- Add exportLocalToPgGenesisSeed with sanitization (expired leases, local absolute paths, .local/ references, Feishu IDs, private materials) and fail-closed privacy boundary scan.
- Add loopx postgres setup and loopx postgres local-to-pg-seed CLI commands.
- Add test suites for checkpoints, sanitization, role assembly, and CLI invocation.

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>

* Recheck the historical Lark reply before each media write

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>

* Retry Lark image uploads after an explicit App scope rejection

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>

* Honor original Lark stop and closure before deferred images

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>

* Recheck private answer control after Lark source read

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>

* Read the current Core session after delayed image controls

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>

* Fence private answer media dispatch with original controls

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>

* Keep Lark media checks with private delivery

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>

* Recheck Lark image sources after recording upload intent

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>

* Read both original Feishu messages together before media upload

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>

* Verify Feishu sources at the guarded image dispatch

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>

* Preserve pre-dispatch Feishu source and session validation

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>

* Recover and verify PostgreSQL checkpoint history with append-only privileges

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>

* Verify backup history to its captured cursor beyond 20000 commits

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>

* Generate explicitly synthetic secret fixtures at test time

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>

* Recover private image uploads when the Lark CLI cannot start

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>

* fix(chat): preserve the first Goal's registered conversation (#8798)

* fix(chat): preserve the first Goal's registered conversation

Signed-off-by: lusendong.6789 <lusendong.6789@bytedance.com>
Co-authored-by: TRAE CLI <traecli@bytedance.com>

* test(chat): keep original Goal adoption compatible with Python 3.11

Signed-off-by: lusendong.6789 <lusendong.6789@bytedance.com>
Co-authored-by: TRAE CLI <traecli@bytedance.com>

---------

Signed-off-by: lusendong.6789 <lusendong.6789@bytedance.com>
Co-authored-by: TRAE CLI <traecli@bytedance.com>

* Avoid rereading delivered Lark settings records and empty queues

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>

* Recover private Lark images after a CLI descriptor limit

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>

* Enable existing checks and the original authorized Task in managed Chat

Signed-off-by: lusendong.6789 <lusendong.6789@bytedance.com>
Co-authored-by: TRAE CLI <traecli@bytedance.com>

* Reuse the canonical boundary projection and narrow Task JSON types

Signed-off-by: lusendong.6789 <lusendong.6789@bytedance.com>
Co-authored-by: TRAE CLI <traecli@bytedance.com>

* Keep confirmed Goal creation attached to its original Task (#8805)

Reuse the existing C1 source observation guard

Signed-off-by: lusendong.6789 <lusendong.6789@bytedance.com>
Co-authored-by: TRAE CLI <traecli@bytedance.com>

* Assert the lease source probe returned an observation (#8796)

(cherry picked from commit 2c099be)

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>

* Recover an owed replan debit before the next host Turn (#8794)

* Recover an owed replan debit before the next host Turn

Consider the original Todo binding when an admitted replan has verified writeback. Require the exact spend receipt before another guard grants delivery, even if the Todo lifecycle has changed. Keep explicit selection on the same recovery path and let the existing settlement owner replay the original debit.

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>

* Preserve ordinary completed-Todo successor admission

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>

* Replay one validated Turn debit across concurrent observations

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>

* Validate original Turn spend terms before debit and replay

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>

---------

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>

* Keep conversation history rendering off the typing path (#8781)

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>

* feat(coordination): complete remote task lifecycle and opt-in gateway access (#8747) (#8765)

* feat(coordination): add complete remote task lifecycle and opt-in gateway access (#8747)

Align with PR #8747 (multi-loopx-agent-cloud-collaboration-v0) and
remote-authority-task-service-v0 (#8508):

1. Extend RemoteAuthorityService with full remote task settlement:
   - Add 'complete', 'block', 'defer', 'todo_add', and 'snapshot' operations.
   - Enforce hard-lease fencing and claim-request ownership checks.
   - Settle completion receipts and deterministic cross-machine snapshot digests.
   - Maintain default-deny Tenant/Goal/Actor authorization and incarnation pinning.

2. Introduce controlled remote authority gateway in Python control plane:
   - Default-disabled access: local private Goals never connect to remote
     authority or leak local credentials.
   - Opt-in gateway metadata projection for explicitly configured goals and
     the 'loopx-quality-review' canary.
   - Fail-closed should-run health check when remote authority is unconfigured
     or unreachable.

3. Conformance and unit test coverage across TypeScript and Python suites.

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>

* test(coordination): assert subprocess readback before decoding

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>

* fix(coordination): qualify explicit remote task reads and lifecycle receipts

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>

* fix(coordination): preserve existing successors on remote completion

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>

* test(remote-authority): prove ordinary admission stays local

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>

---------

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>

* test(chat): preserve create-only intent in workspace selection smoke

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>

* Defer material inventory during configuration discovery (#8807)

Signed-off-by: lusendong.6789 <lusendong.6789@bytedance.com>
Co-authored-by: TRAE CLI <traecli@bytedance.com>

* Defer report providers during Turn reads

Signed-off-by: lusendong.6789 <lusendong.6789@bytedance.com>
Signed-off-by: lusendong.6789 <lusendong.6789@bytedance.com>
Co-authored-by: TRAE CLI <traecli@bytedance.com>

* test(core): require installed provenance before qualification

Signed-off-by: lusendong.6789 <lusendong.6789@bytedance.com>
Co-authored-by: TRAE CLI <traecli@bytedance.com>

* Reuse the final source check for staged Turn requests (#8820)

Signed-off-by: lusendong.6789 <lusendong.6789@bytedance.com>
Co-authored-by: TRAE CLI <traecli@bytedance.com>

* Defer PR wait provider loading until permission is checked (#8821)

Load the optional PR reconciler only after the invocation-time observation permission check, inside the existing provider failure boundary. Preserve original permission, cadence, result and unknown-effect owners, and document the bounded default-closure and timing-window change.

Signed-off-by: lusendong.6789 <lusendong.6789@bytedance.com>
Co-authored-by: TRAE CLI <traecli@bytedance.com>

* Load provider options only for the selected capability editor (#8822)

Signed-off-by: lusendong.6789 <lusendong.6789@bytedance.com>
Co-authored-by: TRAE CLI <traecli@bytedance.com>

* docs: describe README session continuity directly (#8823)

* Skip automatic usage observers for supported opt-outs (#8824)

* Skip automatic usage observers for supported opt-outs

Signed-off-by: lusendong.6789 <lusendong.6789@bytedance.com>
Co-authored-by: TRAE CLI <traecli@bytedance.com>

* Record installed Core and C1 observer qualification

Signed-off-by: lusendong.6789 <lusendong.6789@bytedance.com>
Co-authored-by: TRAE CLI <traecli@bytedance.com>

---------

Signed-off-by: lusendong.6789 <lusendong.6789@bytedance.com>
Co-authored-by: TRAE CLI <traecli@bytedance.com>

* docs(blog): add EdgeBench controlled Context ON vs OFF 10-task score comparison (#8760)

* docs(blog): add EdgeBench controlled Context ON vs OFF 10-task score comparison

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>

* docs(blog): use declarative mechanism-led opening in zh context-delivery score section

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>

---------

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>

* fix(heartbeat): preserve proven waits before their due time (#8825)

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>

* Fix manager discovery in ordinary installs (#8830)

* Package the manager discovery projection

Signed-off-by: lusendong.6789 <lusendong.6789@bytedance.com>
Co-authored-by: TRAE CLI <traecli@bytedance.com>

* Record selected manager discovery distribution qualification

Signed-off-by: lusendong.6789 <lusendong.6789@bytedance.com>
Co-authored-by: TRAE CLI <traecli@bytedance.com>

---------

Signed-off-by: lusendong.6789 <lusendong.6789@bytedance.com>
Co-authored-by: TRAE CLI <traecli@bytedance.com>

* test(workspace): verify confirmed Goal creation against the current contract (#8816)

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>

* Fix Windows CLI output probe reader invocation (#8817)

Port the probe fixture and native Windows regression coverage from e6eb92d and 8d200aa. Decode the generated PowerShell literals into argv before launching the pinned reader.

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>

* refactor(issue_fix): fold reviewer source trust/freshness vocabularies into one owner (#8826)

reviewer_recommendation.py restated the trust and freshness sets that
repository_context.py already owns. Import both as aliases of the owner
objects so the decision has a single source, and add an architecture guard
that pins single ownership by value, by identity, and by wiring through both
public builders. REVIEWER_SOURCE_KINDS stays local (deliberately narrower).

Signed-off-by: psychologister <230141834+psychologister@users.noreply.github.com>
Co-authored-by: psychologister <230141834+psychologister@users.noreply.github.com>

* fix(scheduler): reject superseded heartbeat receipts on the Python follow-up route (#8708)

* fix(scheduler): reject superseded heartbeat receipts on the Python follow-up route

The Python compatibility route for scheduler-ack-current/scheduler-fail-current
checked only that the receipt for --turn-instance-id exists; a receipt already
superseded by a newer heartbeat Turn still committed scheduler state, while the
native TypeScript transaction rejects it as heartbeat_receipt_stale.

Thread the Turn from build_scheduler_followup_payload through
record_quota_scheduler_ack / record_quota_scheduler_ack_for_decision /
record_quota_scheduler_failure_for_decision into _run_native_followup, which now
sends turn_instance_id with require_heartbeat_receipt=true. The TypeScript
transaction remains the single owner of the missing/stale/superseded fence (it
also rechecks under the scheduler state lock); optional parameters keep the
in-process API, which has no Turn, unchanged.

Fixes #8605

Signed-off-by: Lihua <1017343802@qq.com>

* Keep scheduler follow-up hint reads out of legacy migration

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>

---------

Signed-off-by: Lihua <1017343802@qq.com>
Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>
Co-authored-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>

* Resume the original quota settlement after lifecycle writeback (#8728)

* fix(replan): resume settlement after lifecycle review writeback

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>

* Recover committed replan settlement before rebuilding its review

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>

---------

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>

* fix(antigravity): keep the project registry in generated wakes (#8768)

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>

* fix(chat): keep workspace checker reads portable (#8814)

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>

* Reject external Turn retries when the captured work changes (#8828)

* Recheck captured work before launching an external Turn host

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>

* Keep complete-source metadata assembly outside Turn planning

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>

---------

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>

* Preserve PostgreSQL runtime access and recover seed output retries

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>

* Validate recovery cursor metadata without a fixed history ceiling

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>

---------

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>
Signed-off-by: lusendong.6789 <lusendong.6789@bytedance.com>
Signed-off-by: psychologister <230141834+psychologister@users.noreply.github.com>
Signed-off-by: Lihua <1017343802@qq.com>
Co-authored-by: Lusen Dong <lusendong.6789@bytedance.com>
Co-authored-by: TRAE CLI <traecli@bytedance.com>
Co-authored-by: Lusen Dong <cicomaple@gmail.com>
Co-authored-by: psychologister <st040325@gmail.com>
Co-authored-by: psychologister <230141834+psychologister@users.noreply.github.com>
Co-authored-by: Lihua <1017343802@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant