Repository navigation
Keep healthy global Todos visible when a Goal status check fails - #8865
Conversation
Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>
loopx-agent
left a comment
There was a problem hiding this comment.
Reviewer: model_agent · gpt-6.1-sol · OpenAI · runtime_reported · reasoning_effort=max
Approval conclusion (author-owned PR; GitHub blocks formal self-approval)
动机 / Motivation
跨 Goal 查看待办的用户,需要在一个旧 Goal 无法读取时继续看到其他 Goal 的可执行工作。 同一份包含健康 Goal 和已停止旧 Goal 的注册表,主干命令整体返回不可用,候选保留健康 Todo 并标出缺失范围。 File 和 SQLite 的真实 CLI 对照均读回健康任务,缺失 Goal 以警告和不完整覆盖呈现。 本次范围是既有 global-todos 及共享文本投影。实际安装采用和大型注册表成本仍待验证。
改动思路 / Approach
状态诊断和注册范围来自同一次 status 观察,逐 Agent 的资格继续由 quota owner 提供。投影层只缩小可核实的读取范围并保留缺失事实。 保留现有 manager adapter 和渲染入口,修复局部来源失败导致的全局不可用。 在普通入口中,status 对一个已停止但尚未导入的 Goal 报出 canonical source 错误,同时加入合成提醒。候选先核对诊断和登记范围,随后只向可核实的 Goal 请求 quota。未登记目标、全局错误和注册表不可用仍返回 unavailable。恢复缺失来源继续使用原有显式导入流程。
具体改动 / Changes
关键代码讲解
_scoped_status_failure复用既有结构化诊断,核对错误列表、全局错误和同次观察里的registry_member。范围无法证明时保留原拒绝路径。诊断与范围_queue_goal_ids在扫描前排除合成提醒和失败 Goal,保留现有 scan limit。测试中的健康 Goal 只有一次 quota 读取。读取目标build_global_todos把故障数量和来源放入 warnings 与 envelope。独立十项故障样本只展示八条警告,总数仍为十,覆盖为 1/11 且不完整。实际 Markdown 先显示红色覆盖提示,再显示健康 Todo 和失败来源。主入口与结果
规格 docs/reference/protocols/global-manager-command-v0.md。retain-healthy-lanes 由相同 SQLite 场景的 base 失败、head 通过以及 File 复验支持。typed-scope-and-read-budget 覆盖三种不可核实故障的零 quota 调用和单一健康读取。honest-coverage 覆盖警告上限、完整故障数与实际文本读回。
对主干的风险 / Risks
主要风险是局部失败被错误理解为全局健康,或合成提醒成为额外 Goal。当前真实入口与边界检查保留了失败来源和不完整覆盖,未发现这类回归。34 项定向检查与本地四项直接、五项选中预合并检查通过。两项历史 archive 比较在基线和候选均失败,失败位于测试先运行的固定 d4aaaae archive,尚未进入待比较的当前树。此处保留原失败。其余同组 16 项通过。archive 比较顺序
语义与 CI 对齐
复用原诊断与投影 vocabulary,通过 quota owner 保持逐 Agent 资格。未新增执行授权或持久状态。托管 CI 未查询,两个 archive 失败的后续维护与本项改动分别记录。
我的整体评价 / Verdict
可批准。局部来源失败时,用户能继续判断其他 Goal 的工作,长程接续和文字结果的可读性得到改善。架构沿用原状态、quota 和投影 owner,改动范围与已复现问题相称。这是既有 CLI 和 slash-command 文本响应。已读回实际 Markdown 的健康任务、来源警告与覆盖范围,diff 没有改变可视页面。 实际安装版与大型注册表的时延未验证。两个固定历史 archive 比较仍在基线和候选中失败。
English verdict: APPROVE at bb59d18. Real File/SQLite reads retain healthy work and incomplete coverage. Global or unverifiable failures stay closed. The two fixed-archive failures also occur on the immutable base.
Goal And Delivered Outcome
loopx global-todoscan discard every healthy Goal when the status read reports a contract failure scoped to a single registered Goal. A stopped, unmigrated Goal reproduces this through the ordinary global registry. The status queue also contains a synthetic contract alert, which has no Goal quota of its own.The global Todo adapter checks the typed status diagnostics and registry membership from the same observation. It preserves healthy registered lanes, attributes unavailable coverage to the affected Goals, and keeps the envelope incomplete while any registered scope is omitted. The quota owner continues to supply each displayed lane's eligibility. Registry-wide or unverifiable failures return unavailable with zero quota calls.
Author Declaration
cac86bbad92ba99c3430b3f7eaa9632727573821. Global manager source readsScope And Continuation
This change repairs the existing CLI and slash-command projection through their shared renderer and source adapter. The owner can address each unavailable Goal through its existing recovery procedure. Hosted CI and independent review are pending.
Validation
bb59d1827bf13ac4bf5bec6ae0f2232a96e98dc9finishedfor the local checks belowsyntheticandpublic_fixtureregression_paritypassedreal_entrypointpassedreal_backendpassedintegrationpassedregression_parityfailedstaticpassedFrontend / Visual Evidence
The affected first result is the existing text-based
global-todosresponse. In the packaged Markdown check, the projection reports incomplete coverage and names both affected Goals while the healthy rows remain visible.Type of Change
LoopX Area
Boundary Checklist